<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1330/">https://reviewboard.asterisk.org/r/1330/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Tzafrir Cohen.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2011, 2:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated patch. It now changes less and removes a few lines.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simplify the macro AST_GCC_ATTRIBUTE, that has a special case for detecting weakref:
It seems that the separate case for '$2' is only used with detecting weakref (see configure.ac in asterisk). weakref seems to be meaningless for a function with a complete definition, and hence I change $2 to be a flag: if its value is 'no', the function has no body.
The exact same change could be applied as-is to asterisk (autoconf/ast_gcc_attribute.m4 instead of acinclude.m4 ). Also tested to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only tested on Linux. Here is the result from testing the configure script (generated on Debian Squeeze) on several test systems:
centos4: #define HAVE_ATTRIBUTE_weakref 1
centos5: #define HAVE_ATTRIBUTE_weakref 1
centos6: #define HAVE_ATTRIBUTE_weakref 1
sarge: /* #undef HAVE_ATTRIBUTE_weakref */
etch: #define HAVE_ATTRIBUTE_weakref 1
lenny: #define HAVE_ATTRIBUTE_weakref 1
squeeze: #define HAVE_ATTRIBUTE_weakref 1
wheezy: #define HAVE_ATTRIBUTE_weakref 1
Testing for other macros has not changed, so it Should Work[tm].</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/acinclude.m4 <span style="color: grey">(926)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(926)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1330/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>