<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1340/">https://reviewboard.asterisk.org/r/1340/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1340/diff/2/?file=17700#file17700line19" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/CHANGES</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> invite and instead send an empty display name in the from header. This<span class="ew"> </span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> helps to achieve better interoperability with some devices that were<span class="ew"> </span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> reported as having features behave differently when receiving a display<span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cleaning white space.</pre>
</div>
<br />
<p>- jrose</p>
<br />
<p>On August 2nd, 2011, 2:30 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and David Vossel.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2011, 2:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses an issue where Avaya IP500 requires SIP invites not to include the callerid information in quotes in the from header.
The patch was provided by the reporter, but required some minor changes to meet coding standards and to be in line with the way things are done in trunk.
Note: Ignore added verb statements. They are being pulled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I could tell, with this patch the only way to get an empty caller id string was to manually set it with dialplan to set caller ID. This is fine for trunking and peerage I think.
Test Scenario 1:
SIP Peers:
Steve - just a regular realtime sip peer with no remarkable qualities
Jitsi - no caller id manually set, goes through as Jitsi
[jitsi]
type=peer
context=sipphones
host=dynamic
disallow=all
secret=secret
allow=gsm
allow=h264
SIP Jitsi to Steve call:
exten => 2008,1,NoOp(Set CallerID)
exten => 2008,n,NoOp(CallerID = ${CALLERID(name)})
exten => 2008,n,Dial(SIP/Steve,120)
In this case, the callerid was set to "Jitsi" and the From header included "Jitsi" in the display name, presumably forced by the Jitsi client.
Test scenario 2:
Sip peer - Steve (as above)
Dahdi peer - caller id "Oerst Oernymann" (but with umlauted 'O's instead of 'Oe's)
exten => 2008,1,NoOp(Set CallerID)
exten => 2008,n,NoOp(CallerID = ${CALLERID(name)})
exten => 2008,n,Dial(SIP/Steve,120)
In this case, the callerid was set to "asterisk" and the from header followed suit.
Test Scenario 3 and 4:
as above, except...
exten => 2008,1,NoOp(Set CallerID)
exten => 2008,n,Set(CALLERID(name)=)
exten => 2008,n,NoOp(CallerID = ${CALLERID(name)})
exten => 2008,n,Dial(SIP/Steve,120)
And in both of these cases, Jitsi receives no from name for the invite and no "Display-name" is included until after the invite has been responded to.
So all in all, this patch appears to do what it claimed to with comparably minimal impact.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-16198">ASTERISK-16198</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(330571)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(330571)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1340/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>