<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1336/">https://reviewboard.asterisk.org/r/1336/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GR-303 was removed from 1.8 when sig_pri was extracted. The chan_dahdi analog code is there because the radio modes are not in sig_analog. The radio modes need to be moved to sig_analog so all that redundant code in chan_dahdi can be removed. But that is for another patch.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1336/diff/1/?file=17691#file17691line2297" style="color: black; font-weight: bold; text-decoration: underline;">trunk/channels/sig_analog.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void *__analog_ss_thread(void *data)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2297</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">ast_canmatch_extension</span><span class="p">(</span><span class="n">chan</span><span class="p">,</span> <span class="n">chan</span><span class="o">-></span><span class="n">context</span><span class="p">,</span> <span class="n">exten</span><span class="p">,</span> <span class="mi">1</span><span class="p">,</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2297</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">ast_canmatch_extension</span><span class="p">(</span><span class="n">chan</span><span class="p">,</span> <span class="n">chan</span><span class="o">-></span><span class="n">context</span><span class="p">,</span> <span class="n">exten</span><span class="p">,</span> <span class="mi">1</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2298</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">chan</span><span class="o">-></span><span class="n">caller</span><span class="p">.</span><span class="n">id</span><span class="p">.</span><span class="n">number</span><span class="p">.</span><span class="n">valid</span> <span class="o">?</span> <span class="n">chan</span><span class="o">-></span><span class="n">caller</span><span class="p">.</span><span class="n">id</span><span class="p">.</span><span class="n">number</span><span class="p">.</span><span class="n">str</span> <span class="o">:</span> <span class="nb">NULL</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2298</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">chan</span><span class="o">-></span><span class="n">caller</span><span class="p">.</span><span class="n">id</span><span class="p">.</span><span class="n">number</span><span class="p">.</span><span class="n">valid</span> <span class="o">?</span> <span class="n">chan</span><span class="o">-></span><span class="n">caller</span><span class="p">.</span><span class="n">id</span><span class="p">.</span><span class="n">number</span><span class="p">.</span><span class="n">str</span> <span class="o">:</span> <span class="nb">NULL</span><span class="p">)</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2299</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">&&</span> <span class="p"><span class="hl">(</span>(</span><span class="n">exten</span><span class="p">[</span><span class="mi">0</span><span class="p">]</span> <span class="o">!=</span> <span class="sc">'*'</span><span class="p"><span class="hl">)</span></span> <span class="o">||</span> <span class="p"><span class="hl">(</span></span><span class="n">strlen</span><span class="p">(</span><span class="n">exten</span><span class="p">)</span> <span class="o">></span> <span class="mi">2</span><span class="p">)<span class="hl">))</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2299</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">&&</span> <span class="p">(</span><span class="n">exten</span><span class="p">[</span><span class="mi">0</span><span class="p">]</span> <span class="o">!=</span> <span class="sc">'*'</span> <span class="o">||</span> <span class="n">strlen</span><span class="p">(</span><span class="n">exten</span><span class="p">)</span> <span class="o">></span> <span class="mi">2</span><span class="p">)</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2300</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">&&</span> <span class="p">(</span><span class="n">ast_strlen_zero</span><span class="p">(</span><span class="n">ast_pickup_ext</span><span class="p">())</span> <span class="o">||</span> <span class="n">exten</span><span class="p">[</span><span class="mi">0</span><span class="p">]</span> <span class="o">!=</span> <span class="n">ast_pickup_ext</span><span class="p">()[</span><span class="mi">0</span><span class="p">]</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2301</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">||</span> <span class="n">strlen</span><span class="p">(</span><span class="n">exten</span><span class="p">)</span> <span class="o">></span> <span class="n">strlen</span><span class="p">(</span><span class="n">ast_pickup_ext</span><span class="p">())))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test is not going to always work.
ast_pickup_ext() could be an arbitrary length string like: 123456
The test really needs to check to see if the currently dialed digits are start of an extension or the start of any of the special codes. (*70, *69, *67, *72, *73, *60,...)</pre>
</div>
<br />
<p>- rmudgett</p>
<br />
<p>On August 1st, 2011, 3:52 p.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2011, 3:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The call pickup feature did not work on DAHDI devices for anything other than feature codes beginning with * since all feature codes in chan_dahdi were originally hard-coded to begin with *. This patch is also applied to chan_dahdi.c to fix this bug with GR.303.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verified bug with TDM410P. Tested patch with various call pickup feature codes beginning with * and #.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/AST-621">AST-621</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(330488)</span></li>
<li>trunk/channels/sig_analog.c <span style="color: grey">(330488)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1336/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>