<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1331/">https://reviewboard.asterisk.org/r/1331/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1331/diff/1/?file=17669#file17669line35" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/configs/cdr.conf.sample</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">;congestion = no</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the default is no, then this line should be the opposite.</pre>
</div>
<br />
<p>- Alec</p>
<br />
<p>On July 28th, 2011, 12:42 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and David Vossel.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated July 28, 2011, 12:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was a new feature requested some time ago by alecdavis. There was a code review up for it, but after seeing that tests relied on the behavior in its current state, I nixed the patch after committing it.
This resolves the issue of failing tests by making it an option.
What this patch does is, if in cdr.conf congestion=yes is set, calls ending with congestion will be logged to cdr with a disposition of "CONGESTION" instead of "FAILURE" Pretty small change on the surface, but it needs to be optional since some people rely on cdr files for various odds and ends.
I'm currently inclined to think this is a decent way to handle the option, but I'm not 100% sure in the case of what I with the function ast_cdr_congestion when the congestion flag is down.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran testsuite to make sure it doesn't mangle existing tests.
Ran a congested call with congestion=yes in cdr.conf
Ran a congested call with congestion=no in cdr.conf
Ran a congested call with nothing in cdr.conf
Ran a normal call with congestion=yes in cdr.conf</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-14842">ASTERISK-14842</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(330081)</span></li>
<li>/trunk/configs/cdr.conf.sample <span style="color: grey">(330081)</span></li>
<li>/trunk/include/asterisk/cdr.h <span style="color: grey">(330081)</span></li>
<li>/trunk/main/cdr.c <span style="color: grey">(330081)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(330081)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1331/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>