<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/743/">https://reviewboard.asterisk.org/r/743/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/743/diff/8/?file=11503#file11503line566" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/main/tcptls.c</a>
<span style="font-weight: normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int ast_tls_read_conf(struct ast_tls_config *tls_cfg, struct ast_tcptls_session_args *tls_desc, const char *varname, const char *value)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">563</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">strcasecmp</span><span class="p">(</span><span class="n">varname</span><span class="p">,</span> <span class="s">"tlsbindport"</span><span class="p">)</span> <span class="o">||</span> <span class="o">!</span><span class="n">strcasecmp</span><span class="p">(</span><span class="n">varname</span><span class="p">,</span> <span class="s">"sslbindport"</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">564</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tls_desc</span><span class="o">-></span><span class="n">local_address</span><span class="p">.</span><span class="n">sin_port</span> <span class="o">=</span> <span class="n">htons</span><span class="p">(</span><span class="n">atoi</span><span class="p">(</span><span class="n">value</span><span class="p">));</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Was this logic removed for a reason?
This creates a regression by removing the 'tlsbindport' / 'sslbindport' options, and affects all people upgrading to Asterisk 1.8+.
If this is expected behavior we need to document in the CHANGES file and remove the setting from our default config files.</pre>
</div>
<br />
<p>- Paul</p>
<br />
<p>On July 8th, 2010, 12:13 p.m., Simon Perreault wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By Simon Perreault.</div>
<p style="color: grey;"><i>Updated July 8, 2010, 12:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the port of Asterisk to IPv6.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See test report on the mantis issue.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/17565">17565</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(274727)</span></li>
<li>/trunk/apps/app_externalivr.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_multicast_rtp.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/sip/dialplan_functions.c <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/sip/include/dialog.h <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/sip/include/globals.h <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/sip/include/reqresp_parser.h <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(274727)</span></li>
<li>/trunk/channels/sip/reqresp_parser.c <span style="color: grey">(274727)</span></li>
<li>/trunk/include/asterisk/acl.h <span style="color: grey">(274727)</span></li>
<li>/trunk/include/asterisk/config.h <span style="color: grey">(274727)</span></li>
<li>/trunk/include/asterisk/dnsmgr.h <span style="color: grey">(274727)</span></li>
<li>/trunk/include/asterisk/netsock2.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/rtp_engine.h <span style="color: grey">(274727)</span></li>
<li>/trunk/include/asterisk/tcptls.h <span style="color: grey">(274727)</span></li>
<li>/trunk/main/acl.c <span style="color: grey">(274727)</span></li>
<li>/trunk/main/app.c <span style="color: grey">(274727)</span></li>
<li>/trunk/main/config.c <span style="color: grey">(274727)</span></li>
<li>/trunk/main/dnsmgr.c <span style="color: grey">(274727)</span></li>
<li>/trunk/main/http.c <span style="color: grey">(274727)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(274727)</span></li>
<li>/trunk/main/netsock2.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/main/rtp_engine.c <span style="color: grey">(274727)</span></li>
<li>/trunk/main/tcptls.c <span style="color: grey">(274727)</span></li>
<li>/trunk/res/res_rtp_asterisk.c <span style="color: grey">(274727)</span></li>
<li>/trunk/res/res_rtp_multicast.c <span style="color: grey">(274727)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/743/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>