<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1326/">https://reviewboard.asterisk.org/r/1326/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 21st, 2011, 10:57 a.m., <b>Kevin Fleming</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1326/diff/1/?file=17574#file17574line515" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/Makefile</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">515</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nv">OLDHEADERS</span><span class="o">=</span><span class="k">$(</span>filter-out <span class="k">$(</span>NEWHEADERS<span class="k">)</span>,<span class="k">$(</span>notdir <span class="k">$(</span>wildcard <span class="k">$(</span>DESTDIR<span class="k">)$(</span>ASTHEADERDIR<span class="k">)</span>/*.h<span class="k">)))</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">515</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nv">OLDHEADERS</span><span class="o">=</span><span class="k">$(</span>filter-out <span class="k">$(</span>NEWHEADERS<span class="k"><span class="hl">)</span></span><span class="hl"> </span><span class="k"><span class="hl">$(</span></span><span class="hl">notdir </span><span class="k"><span class="hl">$(</span></span><span class="hl">DESTDIR</span><span class="k"><span class="hl">)$(</span></span><span class="hl">ASTHEADERDIR</span><span class="k"><span class="hl">)</span>)</span>,<span class="k">$(</span>notdir <span class="k">$(</span>wildcard <span class="k">$(</span>DESTDIR<span class="k">)$(</span>ASTHEADERDIR<span class="k">)</span>/*.h<span class="k">)))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In my testing on the previous patch, this sort of thing did not work. $(wildcard) assumes that spaces in its arguments separate arguments, and as a result the function does not return the expected results. This needs to be *thoroughly* tested.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This one is fun. Basically, what happens is that notdir trims everything before the final slash in each space separated argument. The intended result is to obtain a list of headers with the leading path removed. So what this does is add the path itself to the part to filter out, which if it contains a space, evaluates to two parts to filter out of the result.
For example, where ASTHEADERDIR=/Library/Application Support/Asterisk/Headers, filter-out additionally removes "Application" and "Headers". Note that all legitimate files in this directory are named with a .h suffix.
I've tested this with both one space and two spaces in the path (one in DESTDIR, one in ASTHEADERDIR), and it works as expected.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 21st, 2011, 10:57 a.m., <b>Kevin Fleming</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1326/diff/1/?file=17574#file17574line607" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/Makefile</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">607</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">ifneq ($(findstring $(space),$(DESTDIR)),)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">608</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> @echo <span class="s2">"DESTDIR does not support paths with spaces at this time. Sorry."</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">609</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"> #@exit 1</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">610</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">endif</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this needed?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can be removed. It was part of my debugging.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 21st, 2011, 10:57 a.m., <b>Kevin Fleming</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1326/diff/1/?file=17574#file17574line611" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/Makefile</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">611</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">ifneq ($(MAKE_PREINSTALL),)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">612</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">$(</span>MAKE_PREINSTALL<span class="k">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">613</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">endif</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there a POSTINSTALL to clean up these symlinks?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There isn't, but we can.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 21st, 2011, 10:57 a.m., <b>Kevin Fleming</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1326/diff/1/?file=17574#file17574line717" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/Makefile</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">708</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> @<span class="o">[</span> -d <span class="k">$(</span>DESTDIR<span class="k">)$(</span>HTTP_DOCSDIR<span class="k">)</span>/ <span class="o">]</span> <span class="o">||</span> <span class="o">(</span> <span class="nb">printf</span> <span class="s2">"http docs directory not found.\nUpdate assignment of variable HTTP_DOCSDIR in Makefile!\n"</span> <span class="o">&&</span> <span class="nb">exit </span>1 <span class="o">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">717</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> @<span class="o">[</span> -d <span class="k">$(</span>DESTDIR<span class="k">)$(</span>HTTP_DOCSDIR<span class="k">)</span>/ <span class="o">]</span> <span class="o">||</span> <span class="o">(</span> <span class="nb">printf</span> <span class="s2">"http docs directory not found.\nUpdate assignment of variable HTTP_DOCSDIR in Makefile!\n"</span> <span class="o">&&</span> <span class="nb">exit </span>1 <span class="o">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">709</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> @<span class="o">[</span> -d <span class="k">$(</span>DESTDIR<span class="k">)$(</span>HTTP_CGIDIR<span class="k">)</span> <span class="o">]</span> <span class="o">||</span> <span class="o">(</span> <span class="nb">printf</span> <span class="s2">"cgi-bin directory not found.\nUpdate assignment of variable HTTP_CGIDIR in Makefile!\n"</span> <span class="o">&&</span> <span class="nb">exit </span>1 <span class="o">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">718</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> @<span class="o">[</span> -d <span class="k">$(</span>DESTDIR<span class="k">)$(</span>HTTP_CGIDIR<span class="k">)</span> <span class="o">]</span> <span class="o">||</span> <span class="o">(</span> <span class="nb">printf</span> <span class="s2">"cgi-bin directory not found.\nUpdate assignment of variable HTTP_CGIDIR in Makefile!\n"</span> <span class="o">&&</span> <span class="nb">exit </span>1 <span class="o">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">710</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">$(</span>INSTALL<span class="k">)</span> -m 4755 contrib/scripts/vmail.cgi <span class="k">$(</span>DESTDIR<span class="k">)$(</span>HTTP_CGIDIR<span class="k">)</span>/vmail.cgi</pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">719</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">$(</span>INSTALL<span class="k">)</span> -m 4755 contrib/scripts/vmail.cgi <span class="k">$(</span>DESTDIR<span class="k">)$(</span>HTTP_CGIDIR<span class="k">)</span>/vmail.cgi</pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">711</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">$(</span>INSTALL<span class="k">)</span> -d <span class="k">$(</span>DESTDIR<span class="k">)$(</span>HTTP_DOCSDIR<span class="k">)</span>/_asterisk</pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">720</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">$(</span>INSTALL<span class="k">)</span> -d <span class="k">$(</span>DESTDIR<span class="k">)$(</span>HTTP_DOCSDIR<span class="k">)</span>/_asterisk</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A number of unquoted references to DESTDIR here.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll get those in the next revision.</pre>
<br />
<p>- Tilghman</p>
<br />
<p>On July 20th, 2011, 7:40 p.m., Tilghman Lesher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.</div>
<div>By Tilghman Lesher.</div>
<p style="color: grey;"><i>Updated July 20, 2011, 7:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Support for spaces in standard paths was recently reverted, because spaces in DESTDIR were not supported. This patch implements changes allowing spaces within both standard application paths (standard on Mac OS X), as well as within DESTDIR.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verified that the install routines run correctly when there are spaces in both standard application paths, as well as in DESTDIR.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/Makefile <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/Makefile.moddir_rules <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/agi/Makefile <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/branches/1.8/configure.ac <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/include/asterisk/autoconfig.h.in <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/makeopts.in <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/sounds/Makefile <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/utils/Makefile <span style="color: grey">(328881)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1326/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>