<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1326/">https://reviewboard.asterisk.org/r/1326/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.</div>
<div>By Tilghman Lesher.</div>
<p style="color: grey;"><i>Updated July 21, 2011, 11:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed Kevin's suggestions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Support for spaces in standard paths was recently reverted, because spaces in DESTDIR were not supported. This patch implements changes allowing spaces within both standard application paths (standard on Mac OS X), as well as within DESTDIR.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verified that the install routines run correctly when there are spaces in both standard application paths, as well as in DESTDIR.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/Makefile <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/Makefile.moddir_rules <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/agi/Makefile <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/branches/1.8/configure.ac <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/include/asterisk/autoconfig.h.in <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/makeopts.in <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/sounds/Makefile <span style="color: grey">(328881)</span></li>
<li>/branches/1.8/utils/Makefile <span style="color: grey">(328881)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1326/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>