<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1312/">https://reviewboard.asterisk.org/r/1312/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great work tracking this down. This looks like it will work until they decide to not offer the old session type. Perhaps someone can come along and write a parser for the new one before then. Regardless, having things work now is always a good thing.</pre>
<br />
<p>- David</p>
<br />
<p>On July 6th, 2011, 11:34 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and David Vossel.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated July 6, 2011, 11:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Calls from a GMail client now offer both a jingle session and the old-style session. This patch detects this and ignores the jingle session and uses the other session instead.
It looks like they are now trying to use the actual Jingle spec, so we will want to take a look at writing a parser for that once they start using it for both GTalk and Google Voice. There are some differences with the temporary one that chan_jingle uses.
This fix is a little hacky, but that is just how it goes until they actually switch to "Real Jingle" everywhere.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I made inbound and outbound GTalk and Google Voice calls and they all rang through.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/channels/chan_gtalk.c <span style="color: grey">(326513)</span></li>
<li>/branches/1.8/include/asterisk/jingle.h <span style="color: grey">(326513)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1312/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>