<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1255/">https://reviewboard.asterisk.org/r/1255/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">David,
Change the if line to:
+ if ((timer_status.it_value.tv_sec == 0) && (timer_status.it_value.tv_nsec == 0L)) {
+ ast_debug(1, "Reading attempt on idle timerfd.\n");
+ return;
+ }
Does the performance degrade then also?
This is part of my submitted patch https://issues.asterisk.org/jira/browse/ASTERISK-17867 (res_timinig_timerfd_read_deadlock.patch)</pre>
<br />
<p>- astmiv</p>
<br />
<p>On June 3rd, 2011, 4:11 p.m., kobaz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and russelb.</div>
<div>By kobaz.</div>
<p style="color: grey;"><i>Updated June 3, 2011, 4:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix for issue https://issues.asterisk.org/view.php?id=18028
And several others.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make enough calls to trigger a read on an idle timer
Wait for message:
Reading attempt on idle timerfd. This would have caused a deadlock.
Deadlock avoided.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/1.8/res/res_timing_timerfd.c <span style="color: grey">(320171)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1255/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>