<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1054/">https://reviewboard.asterisk.org/r/1054/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This approach looks good to me. Keep going! :-)
The only additional thing I'd like to see is more verbose documentation on how to use TestCase. Try to write that as you convert tests.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1054/diff/2/?file=14706#file14706line11" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/tests/manager/login/run-test</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">import os</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">from twisted.internet import reactor</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TestCase imports this already</pre>
</div>
<br />
<p>- Russell</p>
<br />
<p>On December 16th, 2010, 2:35 p.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated 2010-12-16 14:35:49</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Warning: This is a work in progress
I wanted to get some initial feedback about creating an Asterisk TestCase class, tests in the testsuite can inherit. For this first review I have converted 2 tests to use the new TestCase class.
See my inline comments further info, and feedback is required :) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local development box</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/configs/asterisk.options.conf.inc <span style="color: grey">(1227)</span></li>
<li>asterisk/trunk/configs/manager.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/configs/manager.general.conf.inc <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/lib/python/asterisk/__init__.py <span style="color: grey">(1227)</span></li>
<li>asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(1227)</span></li>
<li>asterisk/trunk/runtests.py <span style="color: grey">(1227)</span></li>
<li>asterisk/trunk/tests/manager/login/run-test <span style="color: grey">(1227)</span></li>
<li>asterisk/trunk/tests/udptl/configs/ast1/manager.conf <span style="color: grey">(1227)</span></li>
<li>asterisk/trunk/tests/udptl/configs/ast1/manager.general.conf.inc <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/udptl/configs/ast2/manager.conf <span style="color: grey">(1227)</span></li>
<li>asterisk/trunk/tests/udptl/configs/ast2/manager.general.conf.inc <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/udptl/run-test <span style="color: grey">(1227)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1054/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>