<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1181/">https://reviewboard.asterisk.org/r/1181/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 13th, 2011, 3:46 p.m., <b>Leif Madsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think there are a few more modules that fit into the "unsupported" category such as chan_skinny and chan_mobile (and a few other applications, perhaps app_alarmreceiver), so some discussion may need to happen to get a list of these unsupported/deprecated modules. Additionally, Paul made a good point about making sure the CHANGES file gets updated at the very least.</pre>
</blockquote>
<p>On April 13th, 2011, 5:01 p.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm in favor of this too. Moving the files will break packages (AsteriskNOW, etc), but assuming this happens in trunk it should be enough time for maintainers to handle it. Another option would be to create a symlinks, if we wanted to help ease the pain.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ya I have a separate patch on issue #19117 for 1.8 which simply marks the files as UNSUPPORTED in order to avoid breaking packages. This particular patch would apply to trunk only.</pre>
<br />
<p>- Leif</p>
<br />
<p>On April 13th, 2011, 3:42 p.m., Leif Madsen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Russell Bryant.</div>
<div>By Leif Madsen.</div>
<p style="color: grey;"><i>Updated 2011-04-13 15:42:37</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As Asterisk continues to grow, not every modules receives the same amount of love, and some modules receive no love at all. In order to make it more obvious for users which modules are deprecated or unsupported, I've modified menuselect to show modules in their own menu called "Unsupported Modules". This way as things are deprecated, or they no longer have a reasonable level of support, then they can be moved into this directory.
For modules that get moved here, but someone comes along to support the module, it can of course be moved back to a sub-menu where supported modules live.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran ./configure && make menuselect
I then selected a couple of modules from the directory. After running 'make' I verified only the modules I selected built. Everything looks as it should.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/view.php?id=19117">19117</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/Makefile <span style="color: grey">(313699)</span></li>
<li>trunk/addons/Makefile <span style="color: grey">(313699)</span></li>
<li>trunk/addons/app_mysql.c <span style="color: grey">(313699)</span></li>
<li>trunk/addons/app_saycountpl.c <span style="color: grey">(313699)</span></li>
<li>trunk/addons/cdr_mysql.c <span style="color: grey">(313699)</span></li>
<li>trunk/apps/app_dahdibarge.c <span style="color: grey">(313699)</span></li>
<li>trunk/apps/app_db.c <span style="color: grey">(313699)</span></li>
<li>trunk/apps/app_macro.c <span style="color: grey">(313699)</span></li>
<li>trunk/apps/app_readfile.c <span style="color: grey">(313699)</span></li>
<li>trunk/apps/app_setcallerid.c <span style="color: grey">(313699)</span></li>
<li>trunk/channels/chan_h323.c <span style="color: grey">(313699)</span></li>
<li>trunk/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>trunk/include/asterisk/autoconfig.h.in <span style="color: grey">(313699)</span></li>
<li>trunk/unsupported/Makefile <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/unsupported/app_dahdibarge.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/unsupported/app_db.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/unsupported/app_macro.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/unsupported/app_readfile.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/unsupported/app_setcallerid.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/unsupported/chan_h323.c <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1181/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>