<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Op 08-04-11 01:54, Russell Bryant schreef:
<blockquote
cite="mid:20110407235445.29226.98120@hotblack.digium.com"
type="cite">
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;">
<table style="border: 1px solid rgb(201, 195, 153);"
bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="https://reviewboard.asterisk.org/r/1165/">https://reviewboard.asterisk.org/r/1165/</a>
</td>
</tr>
</tbody>
</table>
<br>
<pre style="white-space: pre-wrap; word-wrap: break-word;">The changes look good to me on a first pass. It would be good to let some of the people complaining about problems on mantis test this.</pre>
<br>
<div>
<table style="border: 1px solid rgb(192, 192, 192);
border-collapse: collapse;" bgcolor="white" border="0"
width="100%">
<thead> <tr>
<th colspan="4" style="border-bottom: 1px solid rgb(192,
192, 192); font-size: 9pt; padding: 4px 8px;
text-align: left;" bgcolor="#f0f0f0"> <a
moz-do-not-send="true"
href="https://reviewboard.asterisk.org/r/1165/diff/1/?file=16088#file16088line3381"
style="color: black; font-weight: bold;
text-decoration: underline;">/branches/1.8/res/res_agi.c</a>
<span style="font-weight: normal;"> (Diff revision 1)
</span> </th>
</tr>
</thead> <tbody style="background-color: rgb(228, 217,
203); padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4">
<pre style="font-size: 8pt; line-height: 140%; margin: 0pt;">static enum agi_result run_agi(struct ast_channel *chan, char *request, AGI *agi, int pid, int *status, int dead, int argc, char *argv[])</pre>
</td>
</tr>
</tbody> <tbody>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);"
align="right" bgcolor="#b1ebb0"><br>
</th>
<td bgcolor="#c5ffc4" width="50%"><br>
</td>
<th style="border-left: 1px solid rgb(192, 192, 192);
border-right: 1px solid rgb(192, 192, 192);"
align="right" bgcolor="#b1ebb0"><font size="2">3381</font></th>
<td bgcolor="#c5ffc4" width="50%">
<pre style="font-size: 8pt; line-height: 140%; margin: 0pt;">ast_log(LOG_NOTICE, "BUGBUG %s hungup\n", chan->name);</pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; word-wrap: break-word;">be sure to remove this debug stuff before merge</pre>
</div>
<br>
<p>- Russell</p>
<br>
<p>On April 7th, 2011, 6:45 p.m., rmudgett wrote:</p>
<table style="background-image:
url("https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png");
background-position: left top; background-repeat: repeat-x;
border: 1px solid black;" bgcolor="#fefadf" cellpadding="8"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<div>Review request for Asterisk Developers and Russell
Bryant.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated 2011-04-07 18:45:06</i></p>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt;
margin-top: 1.5em;">Description </h1>
<table style="border: 1px solid rgb(184, 181, 160);"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">If the call that the dialplan started an AGI script for is hungup while
the AGI script is in the middle of a command then the AGI script is not
notified of the hangup. There are many AGI Exec commands that this can
happen with. The reported applications have been: Background, Wait, Read,
and Dial. Also the AGI Get Data command.
I have restored the AGI script's ability to return the AGI_RESULT_HANGUP
value in run_agi(). It previously only could return AGI_RESULT_SUCCESS or
AGI_RESULT_FAILURE after the DeadAGI and AGI applications were merged.
Should the run_agi() give priority to AGI_RESULT_HANGUP code over the
AGI_RESULT_FAILURE code? The consequence is that the AGI application will
return -1 with the AGI_RESULT_HANGUP code and 0 otherwise.
I have some cleanup changes in this patch as well that I will commit
separately. The fix changes are in run_agi() and __ast_read().
</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt;
margin-top: 1.5em;">Testing </h1>
<table style="border: 1px solid rgb(184, 181, 160);"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">I have setup an AGI script to:
exec Background tt-monkeys
exec Dial SIP phone
The AGI script stops running when expected with the patch and proceeds to
dial the SIP phone without it.
</pre>
</td>
</tr>
</tbody>
</table>
<div style="margin-top: 1.5em;"> <b style="color:
rgb(87, 80, 18); font-size: 10pt; margin-top:
1.5em;">Bugs: </b> <a moz-do-not-send="true"
href="https://issues.asterisk.org/view.php?id=17954">17954</a>,
<a moz-do-not-send="true"
href="https://issues.asterisk.org/view.php?id=18492">18492</a>,
<a moz-do-not-send="true"
href="https://issues.asterisk.org/view.php?id=18935">18935</a>
</div>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt;
margin-top: 1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0pt;">
<li>/branches/1.8/main/channel.c <span style="color:
grey;">(313097)</span></li>
<li>/branches/1.8/res/res_agi.c <span style="color:
grey;">(313097)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="https://reviewboard.asterisk.org/r/1165/diff/"
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by <a class="moz-txt-link-freetext" href="http://www.api-digital.com">http://www.api-digital.com</a> --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
<a class="moz-txt-link-freetext" href="http://lists.digium.com/mailman/listinfo/asterisk-dev">http://lists.digium.com/mailman/listinfo/asterisk-dev</a></pre>
</blockquote>
Will test today..<br>
</body>
</html>