<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1157/">https://reviewboard.asterisk.org/r/1157/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Vossel.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows a jitterbuffer to be placed on the read side of a channel using a dialplan function.
I accomplished this by using framehooks (awesomehooks) to capture audio frames in the read direction of a channel. As frames enter into the framehook callback two things may occur.
1. If the frame is audio, it is placed into the jitterbuffer and then converted to a null frame.
2. If the frame either comes in as a null frame, or is converted from audio to a null frame, the jitter buffer is checked to see if a frame is ready to be released. If this is the case, the null frame is replaced by the next available dejittered frame from the jitterbuffer queue.
Frames are guaranteed to be released at a consistent interval through the use of a timer. The channel listens to this timer's fd causing read to get called each time the timer fires. Read will get called more often that usual with a jitterbuffer on the channel, but frames will not be released until the right delivery time is met.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested this by creating simulated network delay with netem. Delay was set to vary between 200ms-100ms and packets were set to vary in the order they were sent.
A call coming in on the network with delay enters a meetme conference and plays back a file. Another phone is used to connect to that meetme conference without the simulated delay to hear the effect of the network on audio quality. Without the jitterbuffer enabled on the playback channel, the audio being played into the conference sounds terrible. With either an adaptive or fixed jitterbuffer set at at least 200ms in size the audio sounds perfect.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/funcs/func_jitterbuffer.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/abstract_jb.h <span style="color: grey">(312069)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(312069)</span></li>
<li>/trunk/main/abstract_jb.c <span style="color: grey">(312069)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(312069)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1157/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>