<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1148/">https://reviewboard.asterisk.org/r/1148/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please make sure all of your patches have an associated entry in mantis. That's what gets it into our (Digium's) workflow to get it reviewed.
Also, since you've been writing a lot of patches lately, I think it makes sense to go ahead and set you up with commit access, as well. You still need to get sign off through reviewboard before commit, though. You can also use the access to maintain patches in developer branches. Email me to get set up.</pre>
<br />
<p>- Russell</p>
<br />
<p>On March 25th, 2011, 2:40 a.m., irroot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By irroot.</div>
<p style="color: grey;"><i>Updated 2011-03-25 02:40:23</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At first glance this is not needed but there is a application for it.
i have a large site that uses asterisk for all connections to trunks the existing legacy PBX is been phased out
as it has no spares or capacity.
in the dialplan i want to allow call pickup if a call comes in on the DAHDI ports to the PBX i want to set the pickup group from
the real time database and then run the pickup application this can be done with pickup mark this is not ideal as the SIP phones are using
pickupgroup/changroup settings.
small change to allow reading / setting pickupgroup to help transition.
Greg </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/funcs/func_channel.c <span style="color: grey">(311674)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1148/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>