<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1146/">https://reviewboard.asterisk.org/r/1146/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 23rd, 2011, 8:19 a.m., <b>Olle E Johansson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1146/diff/1/?file=15943#file15943line2761" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/apps/app_meetme.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int conf_run(struct ast_channel *chan, struct ast_conference *conf, struct ast_flags64 *confflags, char *optargs[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2761</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_test_flag64</span><span class="p">(</span><span class="o">&</span><span class="n">user</span><span class="o">-></span><span class="n">userflags</span><span class="p">,</span> <span class="n">CONFFLAG_MONITOR</span><span class="p">)</span> <span class="o">?</span> <span class="s">"Listen only"</span> <span class="o">:</span> <span class="n">ast_test_flag64</span><span class="p">(</span><span class="o">&</span><span class="n">user</span><span class="o">-></span><span class="n">userflags</span><span class="p">,</span> <span class="n">CONFFLAG_TALKER</span><span class="p">)</span> <span class="o">?</span> <span class="s">"Talk only"</span> <span class="o">:</span> <span class="s">"Talk and listen"</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not like values with space in them. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're right. I agree with you completely, however it is almost only a copy-paste of some existing code ...</pre>
<br />
<p>- clegall_proformatique</p>
<br />
<p>On March 23rd, 2011, 8:16 a.m., clegall_proformatique wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By clegall_proformatique.</div>
<p style="color: grey;"><i>Updated 2011-03-23 08:16:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The MeetmeList event already provides some useful informations as to the various channels involved in a conference room.
This patch provides the same level of information inside the MeetmeJoin event.
Besides, a field PseudoChan has been added to both events in order to be able to match against the proper DAHDI/pseudo-xxxx channel that is created with the conference.
The patch is provided against the current trunk, but it would be welcome to be included into the 1.8 branch as well, the diff is the same.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_meetme.c <span style="color: grey">(311603)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1146/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>