<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1137/">https://reviewboard.asterisk.org/r/1137/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By irroot.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a most annoying pain and tripped me up no end testing the T38 gateway patch for res_fax.
Scenario :-
i have a Linksys 2102 on a fax machine that uses G.729 and switches to ALAW on CNG and then negotiates T.38
this is awesome as i can now Chat/Fax from same terminal using most effective bandwidth [these are to be deployed
on sugar cane farms surrounding the kruger park here in south africa over wi-fi]
for testing purposes im using a local channel into T.30 fax app in res_fax.
Problem :-
when the device reinvites ALAW then T.38 it leaves the nativeformat on chan_local as G.729 this will not work
as it is transcoding the FAX from G.729 to SLIN this will not work and took me a while to spot the problem.
Soloution :-
Check the format on the proxy and adjust it if it changes this should be what Local does been a proxy of the channel
it should follow changes ...
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/Makefile <span style="color: grey">(310546)</span></li>
<li>/trunk/apps/app_directed_pickup.c <span style="color: grey">(310546)</span></li>
<li>/trunk/apps/app_faxdetect.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(310546)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(310546)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(310546)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(310546)</span></li>
<li>/trunk/channels/h323/ast_h323.h <span style="color: grey">(310546)</span></li>
<li>/trunk/channels/h323/ast_h323.cxx <span style="color: grey">(310546)</span></li>
<li>/trunk/channels/h323/chan_h323.h <span style="color: grey">(310546)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(310546)</span></li>
<li>/trunk/configs/h323.conf.sample <span style="color: grey">(310546)</span></li>
<li>/trunk/configs/queues.conf.sample <span style="color: grey">(310546)</span></li>
<li>/trunk/configs/res_fax.conf.sample <span style="color: grey">(310546)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(310546)</span></li>
<li>/trunk/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(310546)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(310546)</span></li>
<li>/trunk/include/asterisk/dsp.h <span style="color: grey">(310546)</span></li>
<li>/trunk/include/asterisk/res_fax.h <span style="color: grey">(310546)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(310546)</span></li>
<li>/trunk/main/dsp.c <span style="color: grey">(310546)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(310546)</span></li>
<li>/trunk/res/res_fax_spandsp.c <span style="color: grey">(310546)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1137/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>