<meta http-equiv="content-type" content="text/html; charset=utf-8"><span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; ">Just wanted bump it up. :-) I know this is a pretty large patch to something not many people use, but I would really appreciate any feedback :-D</span><br>
<br><div class="gmail_quote">On Tue, Mar 1, 2011 at 1:05 PM, thedavidfactor <span dir="ltr">&lt;<a href="mailto:reviewboard@asterisk.org">reviewboard@asterisk.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">




 <div>
  <div style="font-family:Verdana, Arial, Helvetica, Sans-Serif">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
    <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1129/" target="_blank">https://reviewboard.asterisk.org/r/1129/</a>
     </td>
    </tr>
   </tbody></table>
   <br>


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-repeat:repeat-x;border:1px black solid">
 <tbody><tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By thedavidfactor.</div>





<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I would like feedback on how this is implemented. I feel like hi-jacking the generator to handle the DTMF sending and the recording isn&#39;t the best way to do it, but they both have to happen in queue with the playing prompts.</pre>

  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">running as coded on Asterisk 1.8 branch</pre>
  </td>
 </tr>
</tbody></table>




<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>/trunk/apps/app_externalivr.c <span style="color:grey">(309125)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1129/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>




  </td>
 </tr>
</tbody></table>




  </div>
 </div>


</blockquote></div><br>