<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1130/">https://reviewboard.asterisk.org/r/1130/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Alec Davis.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the process of trying to get DISA working with mobile phones, finished up cleaning a section of dtmf_detect.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on 2 systems.
system 1: On analog FXS connected phone, verified dtmf detection, is still valid.
system 2:. using callfile to call mobile, and then use DISA to sucessfully dial every time.
System 2: Debug logs (with dateformat=%F %T.%3q), show false triggers, with events triggered at appropriate times, 40ms.
[2011-03-03 00:14:39.023] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.023] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.043] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.083] DEBUG[18627] dsp.c: DTMF BEG digit='2' len=0
[2011-03-03 00:14:39.083] DEBUG[18627] chan_dahdi.c: Begin DTMF digit: 0x32 '2' on DAHDI/i1/021XXXXXX-1
[2011-03-03 00:14:39.163] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.183] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.203] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.223] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.303] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.323] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.743] DEBUG[18627] dsp.c: DTMF EDGE
[2011-03-03 00:14:39.783] DEBUG[18627] dsp.c: DTMF END digit='2' len=4590
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/view.php?id=18904">18904</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/main/dsp.c <span style="color: grey">(309081)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1130/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>