<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1119/">https://reviewboard.asterisk.org/r/1119/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By irroot.</div>
<p style="color: grey;"><i>Updated 2011-02-20 11:28:22.067238</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the changroup bits are pointless as they can be done in the dialplan.
modified QUEUE_MEMBER to be read write allowing changing/reading member options, this will allow deprecating
QUEUE_MEMBER_PENALTY.
Modified set penalty to work with realtime and non realtime peers.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is a combination of 3 changes id like to submit.
1)allow a per member ringinuse setting called ignorebusy this was a requirement of a customer and and has been most useful
2)when a call is answered set a channel group this can be used to count active calls as well as be used to not send calls to users flaged above in the dialplan
3)when a member penalty is negative see this as a logged off agent this is a behavior change that allows "removing" realtime agents as well as making IMHO more logic sense if the penalty is neg its not valid
NB: this is a global config option now as not to change behavior.
4)allow a "grace" period for autopause queue option "autopausedelay" [as requested by a customer we support]
Enjoy the fish</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/view.php?id=18794">18794</a>,
<a href="https://issues.asterisk.org/view.php?id=18825">18825</a>,
<a href="https://issues.asterisk.org/view.php?id=18826">18826</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/configs/queues.conf.sample <span style="color: grey">(308283)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(308283)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1119/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>