<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1049/">https://reviewboard.asterisk.org/r/1049/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 10th, 2010, 9:07 a.m., <b>Russell Bryant</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a great start.  I have a suggestion for a further enhancement.

Some tests require a feature of SIPp, not so much a version.  For example, some tests require that it has been built with pcap support.  I think it would be good to be able to specify that as a type of SIPp requirement in the test config file.</pre>
 </blockquote>




 <p>On December 10th, 2010, 9:53 a.m., <b>Paul Belanger</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unless I missed an option, you can specify -TLS, -PCAP, or -TLS-PCAP in your version string.  SIPpVersion will compare both version number an options.  I have not added the proper flags to the tests yet, was looking for help on which ones used -TLS, -PCAP or -TLS-PCAP</pre>
 </blockquote>





 <p>On December 10th, 2010, 10 a.m., <b>Russell Bryant</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can include -TLS, -PCAP, or -TLS-PCAP in the version string.  However, the version number takes precedence over the features.  For example.

&quot;v3.2-PCAP&quot; &gt; &quot;v3.2&quot;

but:

&quot;v3.2&quot; &gt; &quot;v3.1-PCAP-TLS&quot;

I&#39;d like to able to specify both a version number requirement and a specific feature requirement.  I don&#39;t think the feature requirements can be handled through the &gt; comparison exclusively.  They need to be boolean requirements so you can say &quot;I need pcap support but don&#39;t care what SIPp version&quot;, or &quot;I require pcap support and SIPp of at least v3.2&quot;.</pre>
 </blockquote>








</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, I see what you mean, Something like this:

SIPpVersion(&quot;v2.0.1&quot;, &quot;TLS&quot;)
SIPpVersion(&quot;TLS-PCAP&quot;)

---
- sipp :
    - version : &#39;v3.0&#39;
    - feature : &#39;TLS&#39;

- sipp :
    - feature : &#39;TLS-PCAP&#39;</pre>
<br />








<p>- Paul</p>


<br />
<p>On December 9th, 2010, 5:05 p.m., Paul Belanger wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>


<p style="color: grey;"><i>Updated 2010-12-09 17:05:55</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After running into some issue getting the testsuite running under Ubuntu 8.04, it seemed older versions of SIPp fail to parse tabs (/t) properly. So, I replaced them with 4 spaces.

I then ran into an issue of failing tests because my SIPp version did not have the appropriate compile time flags enabled, so I created a new SIPpVersion parser.  I used the AsteriskVersion class as a template, also creating various unit tests to test the parser (very cool and fun BTW).  I&#39;ve defaulted our SIPp based tests to &#39;v3.0&#39; however I know some will require TLS, PCAP or both.  Will need help to confirm which will use it.

Feedback is required :)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">local Ubuntu, FreeBSD and CentOS system.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>asterisk/trunk/lib/python/sipp/version.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/runtests.py <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/app_dial_G_flag/sipp/call.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/app_dial_G_flag/sipp/wait-for-call.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/app_dial_G_flag/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/app_queue/sipp/call-then-hangup.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/app_queue/sipp/call.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/app_queue/sipp/wait-for-call-hangup.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/app_queue/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/call-then-blind-transfer.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/register.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/wait-for-call-do-hangup.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/wait-for-call.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-busy.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-congestion.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/cdr/originate-cdr-disposition/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/queues/position_priority_maxlen/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/queues/ringinuse_and_pause/sipp/uas.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/queues/ringinuse_and_pause/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/rfc2833_dtmf_detect/sipp/broken_dtmf.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/rfc2833_dtmf_detect/sipp/dtmf_baseline.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/rfc2833_dtmf_detect/sipp/dtmf_noend.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/rfc2833_dtmf_detect/sipp/register.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/rfc2833_dtmf_detect/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-200-notify.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-202-error.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-202-notify-provisional.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-202-notify.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-400.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-500.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-603.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/handle_response_refer/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/options/sipp/options.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/options/sipp/options2.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip/options/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_channel_params/sipp/call.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_channel_params/sipp/register.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_channel_params/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_outbound_address/sipp/uas1.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_outbound_address/sipp/uas2.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_outbound_address/test-config.yaml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_register/sipp/registerv4.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_register/sipp/registerv6.xml <span style="color: grey">(1127)</span></li>

 <li>asterisk/trunk/tests/sip_register/test-config.yaml <span style="color: grey">(1127)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1049/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>