<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1051/">https://reviewboard.asterisk.org/r/1051/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 9th, 2010, 1:52 a.m., <b>Alec Davis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Our production boxes are connected to real lines, we only ever used the Called/Calling subaddress to dial in to specific extensions.
We are still running 1.6.2, which doesn't have the chan_dahdi subaddress support. Also now have the luxury of 10Mb fibre between Auckland And Wellington Offices, thus use an IAX trunk.
We don't subscribe to ISDN Transfer/Hold, thus cannot do an ISDN (ETSI) transfer, only can bridge. I could still set it up, but what specifically do I need to test?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am mainly looking to make sure that the correct messages are sent when needed. (Also that I did not break anything. :) )
This scenario may work because you are not doing transfers within the network but sending COLP updates over the network.
1) A calls B over the network.
2) B transfers the call to C that is local.
3) A and C should have each other's subaddresses.</pre>
<br />
<p>- rmudgett</p>
<br />
<p>On December 8th, 2010, 6:39 p.m., rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Alec Davis.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated 2010-12-08 18:39:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add call transfer exchange of subaddresses support.
* Add the ability to exchange subaddresses for ETSI PTMP, ETSI PTP, and
Q.SIG.
* Fix ETSI PTMP to send the correct messages depending on the call state.
JIRA LIBPRI-47
JIRA SWP-2363
Alec, could you give this patch some real line testing? Thanks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Transfered calls with:
1) Q.SIG
2) ETSI PTP
3) ETSI PTMP while call ringing.
4) ETSI PTMP after call answered.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.4/pri.c <span style="color: grey">(2161)</span></li>
<li>/branches/1.4/pri_facility.h <span style="color: grey">(2161)</span></li>
<li>/branches/1.4/pri_facility.c <span style="color: grey">(2161)</span></li>
<li>/branches/1.4/pri_internal.h <span style="color: grey">(2161)</span></li>
<li>/branches/1.4/q931.c <span style="color: grey">(2161)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1051/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>