<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1049/">https://reviewboard.asterisk.org/r/1049/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1049/diff/2/?file=14387#file14387line30" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/lib/python/sipp/version.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def __init__(self, version=None):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="n">version</span> <span class="ow">is</span> <span class="ow">not</span> <span class="bp">None</span><span class="p">:</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Invert if logic</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1049/diff/2/?file=14387#file14387line82" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/lib/python/sipp/version.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def __init__(self, version=None):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">82</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="n">res</span> <span class="o">==</span> <span class="mi">0</span><span class="p">:</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">83</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="bp">self</span><span class="o">.</span><span class="n">tls</span> <span class="o">==</span> <span class="n">other</span><span class="o">.</span><span class="n">tls</span> <span class="ow">and</span> <span class="bp">self</span><span class="o">.</span><span class="n">pcap</span> <span class="o">==</span> <span class="n">other</span><span class="o">.</span><span class="n">pcap</span><span class="p">:</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move to 1 statement</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1049/diff/2/?file=14388#file14388line29" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/runtests.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class Dependency:</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">class</span> <span class="nc">Dependency</span><span class="p">:</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">class</span> <span class="nc">Dependency</span><span class="p">:</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Brain storming with Russell yesterday, it might be time to create a dependency.py file.
For a future patch :)</pre>
</div>
<br />
<p>- Paul</p>
<br />
<p>On December 7th, 2010, 3:48 p.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated 2010-12-07 15:48:56</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After running into some issue getting the testsuite running under Ubuntu 8.04, it seemed older versions of SIPp fail to parse tabs (/t) properly. So, I replaced them with 4 spaces.
I then ran into an issue of failing tests because my SIPp version did not have the appropriate compile time flags enabled, so I created a new SIPpVersion parser. I used the AsteriskVersion class as a template, also creating various unit tests to test the parser (very cool and fun BTW). I've defaulted our SIPp based tests to 'v3.0' however I know some will require TLS, PCAP or both. Will need help to confirm which will use it.
Feedback is required :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">local Ubuntu, FreeBSD and CentOS system.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/lib/python/sipp/version.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/runtests.py <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/app_dial_G_flag/sipp/call.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/app_dial_G_flag/sipp/wait-for-call.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/app_dial_G_flag/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/app_queue/sipp/call-then-hangup.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/app_queue/sipp/call.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/app_queue/sipp/wait-for-call-hangup.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/app_queue/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/call-then-blind-transfer.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/register.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/wait-for-call-do-hangup.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/wait-for-call.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/blind-transfer-accountcode/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-busy.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-congestion.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/cdr/originate-cdr-disposition/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/queues/position_priority_maxlen/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/queues/ringinuse_and_pause/sipp/uas.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/queues/ringinuse_and_pause/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/rfc2833_dtmf_detect/sipp/broken_dtmf.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/rfc2833_dtmf_detect/sipp/dtmf_baseline.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/rfc2833_dtmf_detect/sipp/dtmf_noend.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/rfc2833_dtmf_detect/sipp/register.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/rfc2833_dtmf_detect/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-200-notify.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-202-error.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-202-notify-provisional.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-202-notify.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-400.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-500.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/handle_response_refer/sipp/wait-refer-603.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/handle_response_refer/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/options/sipp/options.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/options/sipp/options2.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip/options/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_channel_params/sipp/call.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_channel_params/sipp/register.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_channel_params/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_outbound_address/sipp/uas1.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_outbound_address/sipp/uas2.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_outbound_address/test-config.yaml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_register/sipp/registerv4.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_register/sipp/registerv6.xml <span style="color: grey">(1103)</span></li>
<li>asterisk/trunk/tests/sip_register/test-config.yaml <span style="color: grey">(1103)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1049/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>