<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/886/">https://reviewboard.asterisk.org/r/886/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Jeff Peeler.</div>
<p style="color: grey;"><i>Updated 2010-12-04 15:50:09.727020</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated code to obtain LWP properly on FreeBSD, Mac, Linux, and Solaris. Removed the old fall back code to use process ID if thread ID could not be obtained. I started with 1.4 since I thought originally the changes would be trivial, but maybe this should just go in trunk. I tested on FreeBSD 8.1, Mac OS X 10.5, and of course Linux (Solaris should be fine).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've run into this problem before and couldn't manage to translate the pthread id to the LWP. I'm not sure if such a mapping exists or not, but let's make debugging easier and just include it. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested creating a thread and verified that core show threads output matched gdb output. I do not know if this will work on non-Linux platforms, hence the review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.4/configure.ac <span style="color: grey">(297580)</span></li>
<li>/branches/1.4/include/asterisk/autoconfig.h.in <span style="color: grey">(297580)</span></li>
<li>/branches/1.4/include/asterisk/utils.h <span style="color: grey">(297580)</span></li>
<li>/branches/1.4/main/asterisk.c <span style="color: grey">(297580)</span></li>
<li>/branches/1.4/main/logger.c <span style="color: grey">(297580)</span></li>
<li>/branches/1.4/main/utils.c <span style="color: grey">(297580)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/886/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>