<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1045/">https://reviewboard.asterisk.org/r/1045/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 2nd, 2010, 5:06 p.m., <b>Russell Bryant</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would rather not get rid of cli_exec(). I would rather just set a convention that we should create a wrapper instead of introducing version checks for CLI syntax inside of a test. Otherwise, when the version thing isn't an issue, cli_exec() is fine.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm fine with that. How do you see version checks happening within the wrappers? Are we going to utilize cli_alias.conf or remove it altogether?</pre>
<br />
<p>- Paul</p>
<br />
<p>On December 2nd, 2010, 3:18 p.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated 2010-12-02 15:18:24</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch deals to 2 issues, removing cli logic to determine Asterisk version (cli_alias.conf) and optimizing fastagi. If needed I can break them out into separate merges, I was tied of waiting for fastagi to finish.
1. Since Asterisk 1.6.2+ has the ability to use CLI alias, we should use it. We'll be adding to the code coverage matrix. I've removed all logic and functions that check the version of Asterisk before issuing a CLI command. Since 1.4 is the oldest revision we are testing with, all CLI syntax MUST be written with 1.4 in mind. If your test is not written for 1.4, you'll then make your CLI commands compatible with the next revision up, 1.6.2.
2. I've reworked the fastagi tests, increasing performance on FreeBSD from 22mins to 2mins. Most of the issues revolved around static timeouts within the tests, I've removed them in favor of dynamic timeouts. I've also move starting / stopping outside the scope of the tests as the test should NOT depend on Asterisk starting or stopping. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local box, and slow FreeBSD system. Both passed.
Asterisk 1.4 and trunk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/fastagi/execute/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/database/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/control-stream-file/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/connect/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/configs/ast1/extensions.conf <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/channel-status/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/directed_pickup/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/chanspy/chanspy_barge/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/callparking/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/configs/cli_aliases.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/fastagi/get-data/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/hangup/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/record-file/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/say-alpha/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/say-date/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/say-datetime/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/say-digits/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/say-number/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/say-phonetic/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/say-time/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/stream-file/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/tests.yaml <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/fastagi/wait-for-digit/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/feature_attended_transfer/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/feature_blonde_transfer/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/iax2/basic-call/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/mixmonitor/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test <span style="color: grey">(1041)</span></li>
<li>asterisk/trunk/tests/one-step-parking/run-test <span style="color: grey">(1041)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1045/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>