<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1045/">https://reviewboard.asterisk.org/r/1045/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1045/diff/2/?file=14218#file14218line248" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/lib/python/asterisk/asterisk.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def install_config(self, cfg_path):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">248</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">def</span> <span class="nf">cli_originate</span><span class="p">(</span><span class="bp">self</span><span class="p">,</span> <span class="n">argstr</span><span class="p">,</span> <span class="n">blocking</span><span class="o">=</span><span class="bp">True</span><span class="p">):</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I disagree with deleting this routine. Really, we should be breaking out the arguments, so that any CLI changes to the order or additional mandatory arguments in the future are dealt with properly.
Additionally, abstracting the command away in the library means that we aren't stuck with 1.4 syntax forever. Once 1.4 is EOLed, we edit only the library, instead of needing to edit umpteen-hundred different tests.</pre>
</div>
<br />
<p>- Tilghman</p>
<br />
<p>On December 2nd, 2010, 10:38 a.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated 2010-12-02 10:38:17</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch deals to 2 issues, removing cli logic to determine Asterisk version (cli_alias.conf) and optimizing fastagi. If needed I can break them out into separate merges, I was tied of waiting for fastagi to finish.
1. Since Asterisk 1.6.2+ has the ability to use CLI alias, we should use it. We'll be adding to the code coverage matrix. I've removed all logic and functions that check the version of Asterisk before issuing a CLI command. Since 1.4 is the oldest revision we are testing with, all CLI syntax MUST be written with 1.4 in mind. If your test is not written for 1.4, you'll then make your CLI commands compatible with the next revision up, 1.6.2.
2. I've reworked the fastagi tests, increasing performance on FreeBSD from 22mins to 2mins. Most of the issues revolved around static timeouts within the tests, I've removed them in favor of dynamic timeouts. I've also move starting / stopping outside the scope of the tests as the test should NOT depend on Asterisk starting or stopping. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local box, and slow FreeBSD system. Both passed.
Asterisk 1.4 and trunk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/fastagi/record-file/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/hangup/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/get-data/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/execute/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/database/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/control-stream-file/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/connect/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/configs/ast1/extensions.conf <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/directed_pickup/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/channel-status/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/chanspy/chanspy_barge/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/callparking/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/configs/cli_aliases.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/one-step-parking/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/mixmonitor/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/iax2/basic-call/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/feature_blonde_transfer/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/feature_attended_transfer/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/wait-for-digit/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/tests.yaml <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/stream-file/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/say-time/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/say-phonetic/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/say-number/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/say-digits/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/say-datetime/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/say-date/run-test <span style="color: grey">(1039)</span></li>
<li>asterisk/trunk/tests/fastagi/say-alpha/run-test <span style="color: grey">(1039)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1045/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>