<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1022/">https://reviewboard.asterisk.org/r/1022/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good.  The only other thing I&#39;d like to see is some notes about this in the README that talks about how to write tests.</pre>
 <br />







<p>- Russell</p>


<br />
<p>On November 19th, 2010, 8:39 a.m., Paul Belanger wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>


<p style="color: grey;"><i>Updated 2010-11-19 08:39:41</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently each test defines their logger.conf ability, making logging inconsistence across all tests.  With this path I&#39;m proposing we define a default logger.conf the testsuite will use.  If tests require additional logger settings, simply create a &#39;logger.conf.inc&#39; file which will be included by &#39;logger.conf&#39;

By default we will set:

1.4 / 1.6.2
[logfiles]
console =&gt; notice,warning,error
full =&gt; notice,warning,error,debug,verbose
--
1.8+
[logfiles]
console =&gt; notice,warning,error
full =&gt; *
--

Having &#39;console =&gt;&#39; only display &#39;notice,warning,error&#39; will help with keeping bamboo output clean.  Any debugging / verbose / fax / etc will be redirected to &#39;full =&gt;&#39;.  If a test creator requires additional control, they should use &#39;messages =&gt;&#39;.

A future patch will standardize the debug and verbose levels, again giving the test creator the ability to override then via the CLI.

Additional convert tests to use &#39;install_configs()&#39;.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local system, all tests passed.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/cdr_unanswered_yes/configs/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/cdr_unanswered_yes/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/cdr_userfield/configs/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/cdr_userfield/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_answer/configs_common/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_answer/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_busy/configs_common/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_busy/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs_common/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_congestion/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs_common/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_transfer/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs_common/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_fork_after_busy_forward/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_fork_before_dial/configs_common/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/console_fork_before_dial/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/nocdr/configs/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/cdr/nocdr/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/chanspy/chanspy_barge/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/configs/branch-1.4/logger.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/configs/branch-1.6.2/logger.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/configs/logger.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/configs/logger.conf.inc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/directed_pickup/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/fastagi/configs/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/feature_attended_transfer/configs/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/feature_attended_transfer/configs2/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/feature_attended_transfer/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/feature_blonde_transfer/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/iax2/basic-call/configs/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/iax2/basic-call/configs2/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/manager/event-monitor/configs/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/manager/event-monitor/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/manager/login/configs/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/manager/login/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/mixmonitor/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/pbx/call-files/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/sip_attended_transfer/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/sip_attended_transfer_tcp/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/sip_attended_transfer_v6/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/sip_one_legged_transfer/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/sip_one_legged_transfer_v6/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/udptl/configs1/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/udptl/configs2/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/udptl/run-test <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/udptl_v6/configs1/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/udptl_v6/configs2/logger.conf <span style="color: grey">(860)</span></li>

 <li>asterisk/trunk/tests/udptl_v6/run-test <span style="color: grey">(860)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1022/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>