<div><br></div><div><div class="gmail_quote">On Mon, Nov 1, 2010 at 6:00 AM, Tzafrir Cohen <span dir="ltr"><<a href="mailto:tzafrir.cohen@xorcom.com">tzafrir.cohen@xorcom.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Mon, Nov 01, 2010 at 07:26:20AM -0500, Shaun Ruffell wrote:<br>
> On 11/01/2010 07:10 AM, Tzafrir Cohen wrote:<br>
<br>
</div><div class="im">> > The way it is used in the drivers of Rhino is something such as:<br>
> ><br>
> > #if DAHDI_VER >= KERNEL_VERSION(2,4,0)<br>
><br>
> Not that it really concerns me, but this doesn't make any sense to me.<br>
> I didn't know the preprocessor does comparisons between strings<br>
> ("SVN-branch-2.3-r9455") and integers ("#define KERNEL_VERSION(a,b,c)<br>
> (((a) << 16) + ((b) << 8) + (c))").<br>
><br>
> Something sounds broken there. My guess is that the Makefile is just<br>
> overwriting include/dahdi/version.h unless there is also another patch<br>
> for the Makefile or build_tools/make_version_h.<br>
<br>
</div>This also breaks with 2.2.1.1 and 2.3.0.1 .<br>
<div class="im"><br>
--<br>
Tzafrir Cohen<br>
icq#16849755 <a href="mailto:jabber%3Atzafrir.cohen@xorcom.com">jabber:tzafrir.cohen@xorcom.com</a><br>
+972-50-7952406 mailto:<a href="mailto:tzafrir.cohen@xorcom.com">tzafrir.cohen@xorcom.com</a><br>
<a href="http://www.xorcom.com" target="_blank">http://www.xorcom.com</a> <a href="http://iax:guest@local.xorcom.com/tzafrir" target="_blank">iax:guest@local.xorcom.com/tzafrir</a><br>
<br>
--<br>
_____________________________________________________________________<br>
</div><div><div></div><div class="h5">-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>
</div></div></blockquote></div><br><meta http-equiv="content-type" content="text/html; charset=utf-8">All,<div><br></div><div>I have passed this over to our devs with tzafrir's off list suggestions. For reference version.h is *NOT* needed to build you can simply pass DAHDI_VER=x.x.x in the make line. I will admit this is not ideal and we will be pushing to get in to the tree which makes this all moot. Also the adjustments made through this logic are not really specific down to the minors so we dont need to match anything outside of x.x to adjust properly. We are always open to suggestions and critique. Note we are on Arizona tome (GMT -7) so it may be a few hours to see things posted by east coasters. If you want to poke a developer directly you can always email me or send a ticket to helpdesk [at] <a href="http://rhinoequipment.com">rhinoequipment.com</a>. The ticket system will get everyones attention :)</div>
<div><br></div>-- <br>James Finstrom<br>Rhino Equipment Corp.<br><a href="http://rhinoequipment.com">http://rhinoequipment.com</a><br><br><br>
</div>