As a community member, I vote to include this in not only the future releases, but in existing<br>releases. My reasoning is that several gui's front end the config files, and any small mods will<br>erase stats. Since Ron's fixes won't change behavior, but allow 'expected' behavior to happen,<br>
I see this as a bug fix.<br><br>Just my 2 cents,<br><br>murf<br><br><br><div class="gmail_quote">On Mon, Aug 16, 2010 at 10:48 AM, Ron Arts <span dir="ltr"><<a href="mailto:ron.arts@netland.nl">ron.arts@netland.nl</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Op 16-08-10 18:27, Mark Michelson schreef:<br>
<div><div></div><div class="h5">> On Mon, 2010-08-16 at 17:51 +0200, Ron Arts wrote:<br>
>> Hi,<br>
>><br>
>> At the moment in 1.6.x and 1.8 beta, a queue reload clears the queue stat counters.<br>
>> I put in a bug report about that, and provided a patch, but it was rejected,<br>
>> because it seems to be expected behaviour as per comments by russellb.<br>
>><br>
>> When warlock52 reported this as a bug a few days ago, pabelanger suggested to<br>
>> involve the community. So that's what I'm doing now.<br>
>><br>
>> Is it to be expected that the queue stats are cleared when a CLI queue reload<br>
>> is issued? I do reloads during the day, and my customers do not appreciate<br>
>> the per-agent call counters, and last call time etc being cleared, because<br>
>> it immediately affects their queue processing.<br>
>><br>
>> What is the reason this is implemented this way?<br>
>><br>
>> Thanks,<br>
>> Ron<br>
>><br>
><br>
> When the "queue reload" command was added in 1.6.2, the idea was to make<br>
> it behave the same way as the command "module reload app_queue.so" from<br>
> previous versions. That command reset statistics, and so the new command<br>
> did the same.<br>
><br>
> Now as to why it worked that way prior to 1.6.2...your guess is as good<br>
> as mine there. How did your proposed patch work? If it just<br>
> unequivocally turned off stat resetting during a reload, it makes sense<br>
> why it would be rejected since there may be those who rely on such<br>
> behavior and changing it mid-release is a bad idea. One idea that could<br>
> be looked into would be to add a qualifier to the end of the "queue<br>
> reload" command that indicates that you do not wish to also be resetting<br>
> the statistics. Even so, I'm not sure that would make it into 1.6.2<br>
> though.<br>
><br>
<br>
</div></div>My patch added a keepstats=yes option in queues.conf which defaulted to<br>
'no', so the default behaviour would retained.<br>
<br>
Ron<br>
<br>
> Mark Michelson<br>
<div class="im">><br>
><br>
<br>
<br>
--<br>
Netland Internet Services BV<br>
bedrijfsmatige internetoplossingen<br>
<br>
<a href="http://www.netland.nl" target="_blank">http://www.netland.nl</a> Science Park 140 1098 XG Amsterdam<br>
info: 020-5628282 servicedesk: 020-5628282 fax: 020-5628281<br>
KvK Amsterdam 33253286<br>
<br>
Op dit bericht is de volgende disclaimer van toepassing:<br>
<a href="http://www.netland.nl/maildisclaimer" target="_blank">http://www.netland.nl/maildisclaimer</a><br>
<br>
--<br>
_____________________________________________________________________<br>
</div><div><div></div><div class="h5">-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Steve Murphy<br>ParseTree Corp<br><br>