<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:2045596200;
mso-list-type:hybrid;
mso-list-template-ids:-630538514 67698703 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=WordSection1>
<p class=MsoNormal>I have been looking at bugid 17680 and see a number of
issues-<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo1'><![if !supportLists]><span
style='mso-list:Ignore'>1.<span style='font:7.0pt "Times New Roman"'>
</span></span><![endif]> Chan_skinny is calling ast_masq_park_call
assuming that ast_bridged_channel<br>
will actually return the remote channel. I am not sure why it does not,<br>
but an easy fix would be to simply set a local variable to the result and<br>
test it before calling ast_masq_park_call<o:p></o:p></p>
<p class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo1'><![if !supportLists]><span
style='mso-list:Ignore'>2.<span style='font:7.0pt "Times New Roman"'>
</span></span><![endif]>Chan_skinny is one of three channel drivers still using
ast_masq_Park_call, the<br>
rest seem to have a locally modified version of masq_park_call-<br>
see sip_park & sip_park_thread. Should chan_skinny follow that
template?<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>My last question is sadly along the lines of C101, but I am
running out of reasonable<o:p></o:p></p>
<p class=MsoNormal>google queries to teach myself what I need to fix bug 12324-<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>A skinny device has reasonable number of active calls that
it can maintain at one time.<o:p></o:p></p>
<p class=MsoNormal>I believe that part of the issue with 12324 is that we do
not track the current call count,<o:p></o:p></p>
<p class=MsoNormal>nor convey it to the phone. The basic 7940 in Call Manager
is identified as supporting<o:p></o:p></p>
<p class=MsoNormal>16 calls, so I am going to use that as a starting point for
my example.<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>I would hate to assign a uint8_t[16] to the line structure
to track the call slots, as<o:p></o:p></p>
<p class=MsoNormal>It seems a waste of space. Would the following work
and be reasonable from<o:p></o:p></p>
<p class=MsoNormal>a space a performance standpoint.<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Add a uint16_t member to the device structure called
callnumber<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Track the calls with bitshifting (here’s where my
googling is failing)<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>for (int count=0; count < 16; count++) {<o:p></o:p></p>
<p class=MsoNormal> if (!(device->callnumber & 1<< count)) {
<o:p></o:p></p>
<p class=MsoNormal> device->callnumber
^= 1<<count;<o:p></o:p></p>
<p class=MsoNormal> break;<o:p></o:p></p>
<p class=MsoNormal> }<o:p></o:p></p>
<p class=MsoNormal>}<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>From here count can be used in transmit_call_info to
identify the call number,<o:p></o:p></p>
<p class=MsoNormal>which has the effect of properly numbering the calls in the
display. We can then<o:p></o:p></p>
<p class=MsoNormal>react to the callnumber in on_hook events to clear the bit.<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Any hints would be appreciate and I apologize for what seems
to be a very basic<o:p></o:p></p>
<p class=MsoNormal>question.<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Dan<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
</div>
</body>
</html>