<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=iso-8859-1">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.E-MailFormatvorlage17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page Section1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=DE link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><span lang=EN-US>Hi guys!<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>While reading through some of the code
today I came across this in main/channel.c (line no. 655 in 1.4.27)<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'>/*! \brief
Pick the best audio codec */<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'>int ast_best_codec(int
fmts)<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'>{<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'> /* This
just our opinion, expressed in code. We are asked to choose<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'> the
best codec to use, given no information */<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'> int x;<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'> static
int prefs[] =<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'> {<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'> /*!
Okay, ulaw is used by all telephony equipment, so start with it */<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'> AST_FORMAT_ULAW,<o:p></o:p></span></p>
<p class=MsoNormal><b><span lang=EN-US style='font-family:Consolas;color:red'> /*!
Unless of course, you're a silly European, so then prefer ALAW */<o:p></o:p></span></b></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'> AST_FORMAT_ALAW,<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-family:Consolas'>…<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>Well, what can I say. I’m European
but I’m definitely not silly. This is not only insulting but also very narrow-minded.
Therefore I kindly request you to remove the “silly” from the
comment in the code.<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>I have no idea who is responsible for that
but for an open source project I suppose that a lot of people have had a look
on this and did not offend, which is kind of awkward.<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>Also I would like to note that u-law is the
suitable codec for North America and Japan, while the majority of the rest of
the world uses a-law (so the “comment” would in fact better fit to
the Americans/Japanese and u-law). <o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>But enough of the talk. Please just remove
the word “silly” from the comment and everyone should be fine.<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:black'>With best regards<br>
<br>
<b>Florian Floimair</b><br>
Firmware Development<br>
<br>
<b>COMMEND INTERNATIONAL GMBH</b><br>
A-5020 Salzburg, Saalachstraße 51<br>
Tel: +43-662-85 62 25<br>
Sip: </span><span style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:black'><a href="sip:f.floimair@commend.com"><span lang=EN-US
style='color:blue'>f.floimair@commend.com</span></a></span><span lang=EN-US
style='font-size:10.0pt;font-family:"Arial","sans-serif";color:black'><br>
Fax: +43-662-85 62 26<br>
</span><span style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:black'><a href="mailto:f.floimair@commend.com"><span lang=EN-US
style='color:blue'>f.floimair@commend.com</span></a></span><span lang=EN-US
style='font-size:10.0pt;font-family:"Arial","sans-serif";color:black'><br>
</span><span style='font-size:10.0pt;font-family:"Arial","sans-serif";
color:black'><a href="http://www.commend.com/"><span lang=EN-US
style='color:blue'>http://www.commend.com</span></a></span><span lang=EN-US
style='font-size:10.0pt;font-family:"Arial","sans-serif";color:black'><br>
<br>
<b>Security and Communication by Commend</b><br>
<br>
</span><span lang=EN-US style='font-size:8.0pt;font-family:"Arial","sans-serif";
color:gray'>FN 178618z | LG Salzburg</span><span lang=EN-US><o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
</div>
</body>
</html>