Hi Tilghman,<br><br> I know you can't, there is a problem with the post-review script. The patch is on the tracker, per KPF's recommendation.<br><br>Nir S<br><br><div class="gmail_quote">On Tue, May 5, 2009 at 1:49 AM, Tilghman Lesher <span dir="ltr"><<a href="mailto:tlesher@digium.com">tlesher@digium.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.digium.com/r/243/#review765" target="_blank">http://reviewboard.digium.com/r/243/#review765</a><br>
-----------------------------------------------------------<br>
<br>
<br>
I cannot view the diff.<br>
<br>
- Tilghman<br>
<br>
<br>
On 2009-05-04 04:00:15, greenfieldtech wrote:<br>
><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.digium.com/r/243/" target="_blank">http://reviewboard.digium.com/r/243/</a><br>
> -----------------------------------------------------------<br>
><br>
> (Updated 2009-05-04 04:00:15)<br>
><br>
><br>
> Review request for Asterisk Developers.<br>
><br>
><br>
> Summary<br>
> -------<br>
><br>
> Over the course of time, developing Asterisk dialplans becomes fairly cumbersome, especially when writing While() loops in the dialplan. Mainly, when we want to iterate a few times, the ever annoying Set(Var=$[${Var} + 1]) is really annoying.<br>
> INCrement and DECrement follow the old PASCAL functions, allowing to increment and decrement a variable.<br>
><br>
> The functions are built to handle both numeric and alpha-numeric values. If an alpha-numeric value is given, the functions will simply bail out and issue a LOG_NOTICE accordingly.<br>
><br>
> In order to implement this, i've added some functionality to func_math.c and added a new ast_is_numeric function to strings.h<br>
><br>
> Please find attached patches for TRUNK under bug tracker issue 15025.<br>
><br>
> For some reason, the post-review script doesn't work (kpf is aware of the issue).<br>
><br>
><br>
> This addresses bug N/A.<br>
> <a href="http://bugs.digium.com/view.php?id=N/A" target="_blank">http://bugs.digium.com/view.php?id=N/A</a><br>
><br>
><br>
> Diffs<br>
> -----<br>
><br>
> /funcs/funcs/func_math.c 191953<br>
><br>
> Diff: <a href="http://reviewboard.digium.com/r/243/diff" target="_blank">http://reviewboard.digium.com/r/243/diff</a><br>
><br>
><br>
> Testing<br>
> -------<br>
><br>
> The below dialplan illustrates the usage of these functions within a dialplan:<br>
><br>
> [incdec]<br>
> exten => _X.,1,Answer<br>
> exten => _X.,n,Wait(1)<br>
> exten => _X.,n,Set(MyVar=10)<br>
> exten => _X.,n,Noop(${INC(MyVar)})<br>
> exten => _X.,n,Noop(MyVAR is Now: ${MyVar})<br>
> exten => _X.,n,Noop(${DEC(MyVar)})<br>
> exten => _X.,n,Noop(MyVAR is Now: ${MyVar})<br>
> exten => _X.,n,While($[DEC(MyVar) > 0])<br>
> exten => _X.,n,Noop(MyVAR is Now: ${MyVar})<br>
> exten => _X.,n,EndWhile<br>
> exten => _X.,n,Noop(${INC(NoVar)})<br>
> exten => _X.,n,Set(NewVar=ab)<br>
> exten => _X.,n,Noop(${INC(NewVar)})<br>
> exten => _X.,n,Noop(NewVAR is Now: ${NewVar})<br>
><br>
><br>
> Screenshots<br>
> -----------<br>
><br>
> INC and DEC running<br>
> <a href="http://reviewboard.digium.com/r/243/s/1/" target="_blank">http://reviewboard.digium.com/r/243/s/1/</a><br>
><br>
><br>
> Thanks,<br>
><br>
> greenfieldtech<br>
><br>
><br>
<br>
<br>
_______________________________________________<br>
--Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank">http://www.api-digital.com--</a><br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>
</blockquote></div><br>