<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 2 5 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page Section1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=ES-UY link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><span lang=EN-US>Hi, I’m having some crashes on local
channel hangup always related to the BRIDGEPEER channel variable.<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>I think there’s a problem in
ast_channel_bridge, when the calls get checked for zombieness <o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> /*
Stop if we're a zombie or need a soft hangup */<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> if
(ast_test_flag(c0, AST_FLAG_ZOMBIE) || ast_check_hangup_locked(c0) ||<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>
ast_test_flag(c1, AST_FLAG_ZOMBIE) || ast_check_hangup_locked(c1)) {<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> *fo
= NULL;<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> if
(who)<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> *rc
= who;<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> res
= 0;<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> ast_log(LOG_DEBUG,
"Bridge stops because we're zombie or need a soft hangup: c0=%s, c1=%s,
flags: %s,%s,%s,%s\n",<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> c0->name,
c1->name,<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> ast_test_flag(c0,
AST_FLAG_ZOMBIE) ? "Yes" : "No",<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> ast_check_hangup(c0)
? "Yes" : "No",<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> ast_test_flag(c1,
AST_FLAG_ZOMBIE) ? "Yes" : "No",<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> ast_check_hangup(c1)
? "Yes" : "No");<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> break;<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> }<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US> /*
See if the BRIDGEPEER variable needs to be updated */<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> if
(!ast_strlen_zero(pbx_builtin_getvar_helper(c0, "BRIDGEPEER")))<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> pbx_builtin_setvar_helper(c0,
"BRIDGEPEER", c1->name);<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> if
(!ast_strlen_zero(pbx_builtin_getvar_helper(c1, "BRIDGEPEER")))<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US> pbx_builtin_setvar_helper(c1,
"BRIDGEPEER", c0->name);<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>It’s not done inside a lock, as it’s
done inside ast_do_masquerade(struct ast_channel *original) when the clone
masquerading member gets destroyed.<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>In all the crashes I’ve seen with gdb
it’s always freeing the BRIDGEPEER variable with a value of local,1
<zombie>, so it was caught in the middle of the masquerading process.<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>I think access to channel->name should
be done inside a lock that also checks for zombieness to be sure we’re
always touching valid memory.(or better yet, to check the bridge is going through
masquerading and stop touching channel members completely)<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>Thoughts?<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>Thanks,<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>Guille<o:p></o:p></span></p>
</div>
</body>
</html>