Thanks, fixed, we didn't need those casts anymore.<br><br><div class="gmail_quote">On Tue, Oct 28, 2008 at 11:34 AM, Kevin P. Fleming <span dir="ltr"><<a href="mailto:kpfleming@digium.com">kpfleming@digium.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d">Eliel Sardaņons wrote:<br>
<br>
> Maybe we can discuss if it makes sense to do those typedefs<br>
> (ast_xml_text and ast_xml_attr). But the casting is being done on<br>
> ->AST_XML_NAME (actually on node->name this is because of a signedness<br>
> warning) and not when working with the typedefs ast_xml_attr and<br>
> ast_xml_text.<br>
> ->name is defined as xmlChar * (libxml2 implementation, maybe 'unsigned<br>
> char *' ??? didn't check it...).<br>
<br>
</div>Well, that is some of it, but I also saw casting of 'paramtype' in pbx.c<br>
which is an ast_xml_attr *. It's inconsistent though... in some places<br>
when it is being passed to ast_true() or ast_false() it is being cast to<br>
'const char *' and in other places it is not being cast at all. Since<br>
it is typedef'd to char anyway, the casts really shouldn't be needed,<br>
but if they are then we need to figure out whether the typedefs are<br>
really providing any value.<br>
<font color="#888888"><br>
--<br>
</font><div><div></div><div class="Wj3C7c">Kevin P. Fleming<br>
Director of Software Technologies<br>
Digium, Inc. - "The Genuine Asterisk Experience" (TM)<br>
<br>
<br>
_______________________________________________<br>
--Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank">http://www.api-digital.com--</a><br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Eliel Sardaņons<br>