I agree with russ and some others, we should make that the policy for all new submitted code, but i dont think we should go back and modify every single if statement without brackets, that would be a nightmare. And the possibility of introducing bugs would be large.<br>
<br><div class="gmail_quote">On Tue, Feb 26, 2008 at 3:40 PM, Russell Bryant <<a href="mailto:russell@digium.com">russell@digium.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">Sergey Tamkovich wrote:<br>
> Tilghman Lesher ?????:<br>
>> I'd like to propose a change to the coding guidelines, and I'm airing it here<br>
>> for specific feedback before we make this change. Currently, our standard<br>
>> is that if you have a single statement following an if/for/while construct,<br>
>> then we do not require parentheses around the single statement. While this<br>
>> is legal C, it has caused a number of issues in the past, where another<br>
>> statement was added at that indentation level, but without adding the<br>
>> necessary braces.<br>
>><br>
>> I'd like to change the coding guidelines that the braces are no longer<br>
>> optional; that they are mandatory,<br>
> +1<br>
<br>
</div>+1 ... sort of. I'd rather it just be "encouraged".<br>
<div class="Ih2E3d"><br>
>> and if this change is approved, a janitor<br>
>> project will be posted shortly to convert legacy code to the new standard.<br>
>><br>
> -1<br>
><br>
> Too complex task, a lot of small changes - the great chance to add a new<br>
> bugs. I think we shouldn't change existing (working) code intentionally.<br>
> We should convert legacy code "as we go" - with other changes<br>
<br>
</div>Make that -2. I think it's a bunch of pointless small changes. I don't mind<br>
encouraging them in the future, but going back and changing the existing code is<br>
pointless IMO.<br>
<font color="#888888"><br>
--<br>
Russell Bryant<br>
Senior Software Engineer<br>
Open Source Team Lead<br>
Digium, Inc.<br>
</font><div><div></div><div class="Wj3C7c"><br>
_______________________________________________<br>
--Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank">http://www.api-digital.com--</a><br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>
</div></div></blockquote></div><br>