Thanks, I've reported. I can help in testing or coding....<br><br><div class="gmail_quote">On Jan 29, 2008 6:55 PM, asterisk <<a href="mailto:Asterisk@isgcom.com">Asterisk@isgcom.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p><font color="navy" face="Arial" size="2"><span style="font-size: 10pt; font-family: Arial; color: navy;">Very Nice! This has been a big issues
with asterisk. I look forward to seeing it in the Bug tracker..</span></font></p>
<p><font color="navy" face="Arial" size="2"><span style="font-size: 10pt; font-family: Arial; color: navy;"> </span></font></p>
<p><font color="navy" face="Arial" size="2"><span style="font-size: 10pt; font-family: Arial; color: navy;">Doug</span></font></p>
<p><font color="navy" face="Arial" size="2"><span style="font-size: 10pt; font-family: Arial; color: navy;"> </span></font></p>
<p><font color="navy" face="Arial" size="2"><span style="font-size: 10pt; font-family: Arial; color: navy;"> </span></font></p>
<div>
<div style="text-align: center;" align="center"><font face="Times New Roman" size="3"><span style="font-size: 12pt;">
<hr align="center" size="2" width="100%">
</span></font></div>
<p><b><font face="Tahoma" size="2"><span style="font-size: 10pt; font-family: Tahoma; font-weight: bold;">From:</span></font></b><font face="Tahoma" size="2"><span style="font-size: 10pt; font-family: Tahoma;">
<a href="mailto:asterisk-dev-bounces@lists.digium.com" target="_blank">asterisk-dev-bounces@lists.digium.com</a>
[mailto:<a href="mailto:asterisk-dev-bounces@lists.digium.com" target="_blank">asterisk-dev-bounces@lists.digium.com</a>] <b><span style="font-weight: bold;">On Behalf Of </span></b>Andrey Sofronov<br>
<b><span style="font-weight: bold;">Sent:</span></b> Tuesday, January 29, 2008
11:39 AM<br>
<b><span style="font-weight: bold;">To:</span></b> <a href="mailto:asterisk-dev@lists.digium.com" target="_blank">asterisk-dev@lists.digium.com</a><br>
<b><span style="font-weight: bold;">Subject:</span></b> [asterisk-dev] Patch:
SIP: choosing common codec and select "free"codec for transcoding</span></font></p>
</div><div><div></div><div class="Wj3C7c">
<p><font face="Times New Roman" size="3"><span style="font-size: 12pt;"> </span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12pt;">Hello all!<br>
<br>
In my network there are a lot of hardware VoIP gateways and softphones and I
have to make then work. Most of all hardware VoIP gateways support G.711, G.723
and G.729 codecs and the softphones support G.711, GSM, iLBC etc codecs. All
endpoints are SIP peers. All traffic should pass through my asterisk server(s).
In "vanilla" asterisk there is a limitation - it is unable to select
a common codec for 2 peers using some algorithm (less bandwidth etc) or if
jointcapability = 0 select codecs for both endpoints that could be transcoded
"for free".<br>
<br>
<b><span style="font-weight: bold;">1st example</span></b>:<br>
<br>
sip.conf<br>
<br>
[210]<br>
disallow=all<br>
allow=alaw,ulaw,g723,g729<br>
...<br>
<br>
[220]<br>
disallow=all<br>
allow=alaw,ulaw,g723,g729<br>
...<br>
<br>
[255]<br>
disallow=all<br>
allow=gsm<br>
...<br>
<br>
210 calls 220:<br>
sip show channels<br>
Peer
User/ANR Call ID Seq
(Tx/Rx)
Format
Hold Last Message<br>
10.xx.xx.xx
220 10aa3d3754b
00102/00000 0x8 (alaw)
No Init: INVITE<br>
10.xx.xx.xx
210 a983a543-52
00101/00939 0x8 (alaw)
No Rx: INVITE<br>
<br>
Works, but alaw is a high-bandwidth codec!<br>
<br>
210 calls 255:<br>
sip show channels<br>
Peer
User/ANR Call ID Seq
(Tx/Rx)
Format
Hold Last Message<br>
10.xx.xx.xx 255
504c907f5b7 00102/00000 0x2
(gsm) No
Init: INVITE<br>
10.xx.xx.xx
210 5f84a543-9c
00101/00943 0x8 (alaw)
No Rx: INVITE<br>
<br>
Works here...<br>
<br>
<b><span style="font-weight: bold;">2nd example</span></b>:<br>
<br>
sip.conf<br>
<br>
[210]<br>
disallow=all<br>
allow=g729,alaw,ulaw,g723<br>
...<br>
<br>
[220]<br>
disallow=all<br>
allow=g729,alaw,ulaw,g723<br>
...<br>
<br>
[255]<br>
disallow=all<br>
allow=gsm<br>
...<br>
<br>
210 calls 220:<br>
sip show channels<br>
Peer
User/ANR Call ID Seq
(Tx/Rx)
Format
Hold Last Message<br>
10.xx.xx.xx
220 572052d8348
00102/00000 0x100 (g729) No Tx:
ACK<br>
10.xx.xx.xx
210 0486a543-2e
00101/00946 0x100 (g729)
No Rx: ACK<br>
<br>
Good work - g729 pass-through!<br>
<br>
210 calls 255:<br>
WARNING[8424]: chan_sip.c:3001 sip_call: No audio format found to offer.
Cancelling call to 255<br>
<br>
All codecs are same, but their order was changed.<br>
<br>
It's a simple example, just to point a problem.<br>
<br>
I'm not a professional C/C++ programmer, but the feature was necessary so I
created a small patch (for asterisk 1.4.17).<br>
<br>
In brief:<br>
1) set sip_pvt->prefcodec = 0!<br>
2) Thanks to 1) asterisk continues execution and calls
ast_channel_make_compatible function.<br>
3) In "ast_channel_make_compatible" we recalculate peers' codec
capabilities and sip_pvt->prefs.<br>
<br>
Result - the order of the codecs in "allow=" parameter does not
matter anymore. Asterisk will select most efficient codec for pass-through and
if jointcapability = 0 will select free and ecomonic codec for transcoding.<br>
<br>
My patch is not excellent (maybe even awful, but i'm not a programmer and it
works for me fine!) but if anybody get an idea, you can make it better. Also it
would be nice to implement that feature as configuration parameter.<br>
<br>
Please see patch in attachment! Thanks! </span></font></p>
</div></div></div>
</div>
<br>_______________________________________________<br>--Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank">http://www.api-digital.com--</a><br><br>asterisk-dev mailing list<br>To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br>