The issue opened for this "janitor" is: 0011096 <br><br>Thanks<br><br><div><span class="gmail_quote">On 10/25/07, <b class="gmail_sendername">Eliel Sardanons</b> <<a href="mailto:eliel@eliel.com.ar">eliel@eliel.com.ar
</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Ok Moises,<br> I will submit the first patch and open an issue to start working on this janitor.
<div><span class="e" id="q_115d8c17b9f827d2_1"><br><br><br><br><div><span class="gmail_quote">On 10/25/07, <b class="gmail_sendername">Moises Silva</b> <<a href="mailto:moises.silva@gmail.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
moises.silva@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Eliel,<br><br>Let us know if you open a bug in mantis for this in order to put
<br>changes there as well.<br><br>Thanks<br><br>Moy<br><br>On 10/25/07, Eliel Sardanons <<a href="mailto:eliel@eliel.com.ar" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">eliel@eliel.com.ar</a>
> wrote:<br>> This are load_module()'s return values, I am not changing nothing, this is
<br>> just the way "it should be", read chan_sip.c and you will notice how<br>> 'return AST_MODULE_LOAD_SUCCESS' is being used.<br>> But if you take a look at some modules (chan_gtalk.c), they don't use this
<br>> return values defined in the enum, they use just the values "0, -1,1,2" and<br>> we should change everything to start using the names<br>> AST_MODULE_LOAD_SUCCESS, *_DECLIE, *_SKIP, etc.<br>><br>
> Sample:<br>> - return 0;<br>> + return AST_MODULE_LOAD_SUCCESS;<br>><br>><br>><br>> On 10/25/07, Tzafrir Cohen <<a href="mailto:tzafrir.cohen@xorcom.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
tzafrir.cohen@xorcom.com</a> > wrote:<br>
> > On Thu, Oct 25, 2007 at 02:09:02PM -0300, Eliel Sardanons wrote:<br>> > > I think we could start a new janitor project to replace every 'return'<br>> on<br>> > > load_module's with:
<br>> > ><br>> > > enum ast_module_load_result {<br>> > > AST_MODULE_LOAD_SUCCESS = 0, /*!< Module loaded and<br>> configured */<br>> > > AST_MODULE_LOAD_DECLINE = 1, /*!< Module is not configured */
<br>> > > AST_MODULE_LOAD_SKIP = 2, /*!< Module was skipped for some<br>> > > reason */<br>> > > AST_MODULE_LOAD_FAILURE = -1, /*!< Module could not be loaded<br>> > > properly */
<br>> > > };<br>> ><br>> > What do those return values mean? Does a return value of -1 mean that<br>> > Asterisk should die?<br>> ><br>> > --<br>> > Tzafrir Cohen
<br>> > icq#16849755 jabber:<a href="mailto:tzafrir.cohen@xorcom.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">tzafrir.cohen@xorcom.com</a><br>> > +972-50-7952406 mailto:
<a href="mailto:tzafrir.cohen@xorcom.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">tzafrir.cohen@xorcom.com
</a><br>> > <a href="http://www.xorcom.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://www.xorcom.com</a><br>> <a href="http://iax:guest@local.xorcom.com/tzafrir" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
iax:guest@local.xorcom.com/tzafrir</a><br>> ><br>> > _______________________________________________
<br>> > --Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://www.api-digital.com--</a><br>> ><br>> > asterisk-dev mailing list
<br>> > To UNSUBSCRIBE or update options visit:
<br>> > <a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>> >
<br>><br>><br>><br>> --<br>> Eliel Sardaņons<br>> _______________________________________________
<br>> --Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://www.api-digital.com--</a><br>><br>> asterisk-dev mailing list
<br>> To UNSUBSCRIBE or update options visit:<br>>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>><br><br><br>--<br>"Within C++, there is a much smaller and cleaner language struggling
<br>
to get out."<br><br>_______________________________________________<br>--Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
http://www.api-digital.com--</a><br><br>asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br> <a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://lists.digium.com/mailman/listinfo/asterisk-dev
</a><br></blockquote></div><br><br clear="all"><br></span></div><span class="sg">-- <br>
Eliel Sardaņons
</span></blockquote></div><br><br clear="all"><br>-- <br>Eliel Sardaņons