<html>
<body>
Sorry for the previous empty message, here are the contents that was
supposed to be inside...<br><br>
This looks like a great idea. However I've got some
questions.<br><br>
You indicate you are making some decision based upon whether or not an
endpoint is registered or static. What happens if a static endpoint
is really just a SIP UA EP? What happens if a softswitch you are
serving as voicemail media for is registering with you instead of being
static?<br><br>
Would it work better if you added a special argument to the
sip.conf?<br><br>
instead of <br><br>
<a href="mailto:mailbox=12895551001@suppc5cm1,12895551002@suppc5cm1,12455551000@suppc5cm1">mailbox=12895551001@suppc5cm1,12895551002@suppc5cm1,12455551000@suppc5cm1</a><br><br>
how about:<br><br>
remotemailbox<a href="mailto:mailbox=12895551001@suppc5cm1,12895551002@suppc5cm1,12455551000@suppc5cm1">=12895551001@suppc5cm1,12895551002@suppc5cm1,12455551000@suppc5cm1</a><br><br>
That way you leave the decision of whether or not the host statement is
static or dynamic to remain a functional decision versus a policy
argument. (I could just be misunderstanding your detailed
description as well)<br><br>
On similar another note, I've been thinking about something I think would
be valuable.<br><br>
<br><br>
How difficult would it be to create a dialplan command that could assign,
un-assign, etc. MWI pointers on the fly? How would this fit in with
your changes here?<br><br>
For example:<br><br>
exten => s,1,MWISet(SIP/1234,1001@office) ;set MWI for SIP/1234
to 1001@office <br><br>
exten => s,1,MWIClear(SIP/1234) ;remove all MWI setting for
SIP/1234<br><br>
exten => s,1,MWISet(SIP/1234,2222@softswitch,r) ; same as above
except r options indicates this is a remote softswitch.<br><br>
<br>
-Chris<br><br>
<br>
On 12:45 PM 4/14/2005, Jay Ray wrote:<br><br>
<blockquote type=cite class=cite cite="">Here is relevant portion of
sip.conf. for those peer softswitches....I have tested with 2 Clarent
Softswitches one with 3 and other with just one mailbox..worked fine. I
will go to bugs.digium.com..and submit a case....Thx<br>
<br>
I followed the NOTIFY mechanism for sending MWI as per RFC 3842....<br>
<br>
<br>
---------------------------------------------------------------sip.conf---------------------------------------<br>
[10.1.1.1:5080] //This
sofswitch uses port 5080 for VoiceMail...we do have to <br>
explicitly mention the port here so that Asterisk does not loose it while
<br>
sending NOTIFY to Softswitches..I found out that Asterisk does loose
<br>
this port.<br>
type=friend<br>
username=c5cm<br>
context=clarentcm<br>
dtmfmode=rfc2833<br>
host=10.1.1.1<br>
<a href="mailto:mailbox=12895551001@suppc5cm1,12895551002@suppc5cm1,12455551000@suppc5cm1">mailbox=12895551001@suppc5cm1,12895551002@suppc5cm1,12455551000@suppc5cm1</a><br>
allow=ulaw<br>
port=5080<br>
[10.1.1.2:5080]<br>
type=friend<br>
context=JerryC5_84<br>
dtmfmode=rfc2833<br>
host=10.1.1.2<br>
<a href="mailto:mailbox=15142550001@jerryc5vm">mailbox=15142550001@jerryc5vm</a><br>
allow=ulaw<br>
port=5080<br>
--------------------------------------------------------------------------------------------------------------------------------------------<br><br>
<br>
<b><i>John Todd <jtodd@loligo.com></i></b> wrote:
<dl>
<dd>This looks interesting. Can you provide a bit more detail and some
<dd>other updates?<br>
<dd>1) Can you supply a diff on the sip.conf file that shows an example
<dd>of your new method (comment the section out, and use several lines of
<dd>comments to explain what the example does)<br>
<dd>2) On what softswitches is this known to work? I assume you've
<dd>tested with SER, as a baseline?<br>
<dd>3) Have you signed a disclaimer with Digium?<br>
<dd>4) Can you submit this as an addition to bugs.digium.com so that it
<dd>will be included in future Asterisk releases if it meets approval and
<dd>functionality criteria (as nebulous as both of those are...)?<br>
<dd>JT<br>
<br>
<dd>At 11:05 AM -0700 on 4/14/05, Jay Ray wrote:
<dd>>Hi All,
<dd>>
<dd>> I had proposed the changes to be able to support Asterisk
<dd>>VoiceMail for 3rd Party Softswitches. Here is what I have changed
o n
<dd>>Asterisk in chan_sip.c
<dd>>
<dd>>While in function sip_send_mwi_to_peer() . in case
peer->tohost has
<dd>>a value which means that its not a registered EP - but a static
<dd>>peer, I call another function called sip_send_mwi_to_softswitch()
<dd>>.....in which I separate the comma separated mailboxes defined in
<dd>>sip.conf for that peer. and send NOTIFY in a for loop for each of
<dd>>the Mailboxes....by calling another new function
<dd>> transmit_notify_to_softswitch_with_mwi()
<dd>>
<dd>>In transmit_notify_to_softswitch_with_mwi() , I populate the
<dd>>sip_pvt->username with the mailbox number (minus the mailbox
<dd>>context, if any)...so that the mailbox number gets added to the
"TO"
<dd>>header in the NOTIFY going out to that Softswitch...for the
<dd>>Softswitch to pass on the NOTIFY to the appropriate
Endpoint....
<dd>>
<dd>>The DIFF is below, comments appreciated.......
<dd>>
<dd>>
<dd>>
<dd>>
<dd>>[root@jerrylinux channels]# diff chan_sip.c.wrking1
chan_sip.c.orig
<dd>>489,490d488
<dd>>< int *lastmsgsent_switch; /* maintaining last message
<dd>>sent for EPS on a Third Party Softswitch */
<dd>><
<dd>>1207c1205
<dd>><
<dd>>---
<dd>>>
<dd>>1209d1206
<dd>><
<dd>>1212d1208
<dd>><
<dd>>3930,3932d3925
<dd>><
<dd>><
<dd>><
<dd>>4217,4271d4209
<dd>>< /*--- transmit_notify_to_softswitch_with_mwi: Notify
Softswitch user of
<dd>>< messages waiting in voicemail ---*/
<dd>>< /* Notification works for Softswitch peers with mailbox=
definitions
<dd>>< * in sip.conf
<dd>>< * We use the SIP Event package message-summary
<dd>>< * MIME type defaults to
"application/simple-message-summary";
<dd>>< */
<dd>>< static int transmit_notify_to_softswitch_with_mwi(struct
sip_pvt
<dd>>*p, char *mbox, int newmsgs, int oldmsgs)
<dd>>< {
<dd>>< struct sip_request req;
<dd>>< char tmp[256];
<dd>>< char tmp2[256];
<dd>>< char *tmp_mbox;
<dd>>< char clen[20];
<dd>><
<dd>>< /* I will put the Mailbox Number - the part before the @
<dd>>< * in p->username, and then call initreqprep as
initreqprep
<dd>>< * looks for a p->username and puts it in TO Header
<dd>>< */
<dd>><
<dd>>< tmp_mbox = (char*) calloc(strlen(mbox), sizeof(char));
<dd>><
<dd>>< strncpy(tmp_mbox, mbox, strlen(mbox));
<dd>><
<dd>>< tmp_mbox = strsep(&tmp_mbox, "@");
<dd>><
<dd>>< strncpy(p->username, tmp_mbox, strlen(tmp_mbox));
<dd>><
<dd>><
<dd>><
<dd>>< initreqprep(&req, p, "NOTIFY", NULL);
<dd>><
<dd>>< add_header(&req, "Event",
"message-summary");
<dd>>< add_header(&req, "Content-Type",
default_notifymime);
<dd>><
<dd>>< snprintf(tmp, sizeof(tmp), "Messages-Waiting:
%s\r\n",
<dd>>ne wmsgs ? "yes" : "no");
<dd>>< snprintf(tmp2, sizeof(tmp2), "Voice-Message: %d/%d\r
\n",
<dd>>newmsgs, oldmsgs);
<dd>>< snprintf(clen, sizeof(clen), "%d",
(int)(strlen(tmp) +
<dd>>strlen(tmp2)));
<dd>>< add_header(&req, "Content-Length", clen);
<dd>>< add_line(&req, tmp);
<dd>>< add_line(&req, tmp2);
<dd>><
<dd>>< if (!p->initreq.headers) {
<dd>>< /* Use this as the basis */
<dd>>< copy_request(&p->initreq, &req);
<dd>>< parse(&p->initreq);
<dd>>< if (sip_debug_test_pvt(p))
<dd>>< ast_verbose("%d headers, %d lines\n",
<dd>>p->initreq.headers, p->initreq.lines);
<dd>>< determine_firstline_parts(&p->initreq);
<dd>>< }
<dd>><
<dd>>< return send_request(p, &req, 1, p->ocseq);
<dd>>< }
<dd>><
<dd>><
<dd>>8628,8734d8565
<dd>>< //Ujju - sip_send_mwi_to_softswitch : Sending MWI to another
Softswitch.
<dd>>< static int sip_send_mwi_to_softswitch(struct sip_peer
*peer)
<dd>>< {
<dd>>< /* Checking for all the m alboxes configured for a
softswitch
<dd>>< and sending NOTIFY w/MWI for all */
<dd>>< struct sip_pvt *p;
<dd>>< char name[256] = "";
<dd>>< int newmsgs, oldmsgs;
<dd>><
<dd>>< if(peer->mailbox==NULL){
<dd>>< ast_log(LOG_WARNING, "No Mailboxes defined in sip.conf
and
<dd>>voicemail.conf for this softswitch");
<dd>>< return 0;
<dd>>< }
<dd>><
<dd>>< int i;
<dd>>< int mbox_count=0;
<dd>>< char *mbox[500]; /*Pointer to individual malboxes*/
<dd>>< char *tmp=NULL; /*Temp Pointer to individual mailboxes*/
<dd>>< char *mailboxes;/* storing full comma separated mailbox
<dd>>string here */
<dd>><
<dd>>< mailboxes=(char
*)calloc(strlen(peer->mailbox),sizeof(char));
<dd>><
<dd>>< strcpy(mailboxes,peer->mailbox);
<dd>><
<dd>><
<dd>>< tmp=strchr(mailboxes,',');
<dd>>< //**mbox=(char **)malloc(sizeof(char *)*256);
<dd>>< //This copies first Mailbox in mbox[0]
<dd>>< mbox[mbox_count]=mailboxes;
<dd>>< mbox[mbox_count]=strsep(&mbox[mbox_count],
",");
<dd>><
<dd>>< //This copies rest of the mailboxes in mbox[1, 2, 3......]
<dd>>< while(tmp!=NULL)
<dd>>< {
<dd>>< mbox_count++;
<dd>>< tmp+=1;
<dd>>< mbox[mbox_count]=(char*) calloc(strlen(tmp),
sizeof(char));
<dd>>< strncpy(mbox[mbox_count],tmp, strlen(tmp));
<dd>>< mbox[mbox_count]=strsep(&mbox[mbox_count],
",");
<dd>>< tmp=strchr(tmp,',');
<dd>>< }
<dd>><
<dd>><
<dd>>< /* Allocating memory for PTR to last msg for each mailbox
<dd>>for EPs on Softswitch */
<dd>>< if (peer->lastmsgsent_switch == NULL) {
<dd>>< peer->lastmsgsent_switch = (int *)
<dd>>calloc(mbox_count,sizeof(int));
<dd>>< for (i=0;i<=mbox_count;i++)
<dd>>< peer->lastmsgsent_switch[i]=-1;
<dd>>< }
<dd>><
<dd>><
<dd>>< //Now looping through all the Mailboxes to send individual
Notify's
<dd>>< for(i=0;i<=mbox_count;i++) {
<dd>><
<dd>><
<dd>>< ast_app_messagecount(mbox[i], &newmsgs, &oldmsgs);
<dd>><
<dd>>< time(&peer->lastmsgcheck);
<dd>><
<dd>>< /* Retur n now if it's the same thing we told them
<dd>>last time */
<dd>>< if (((newmsgs << 8) | (oldmsgs)) ==
<dd>>peer->lastmsgsent_switch[i]) {
<dd>>< if (i==mbox_count)
<dd>>< return 0;
<dd>>< else
<dd>>< continue;
<dd>>< }
<dd>><
<dd>>< p = sip_alloc(NULL, NULL, 0);
<dd>>< if (!p) {
<dd>>< ast_log(LOG_WARNING, "Unable to build sip
<dd>>pvt data for MWI\n");
<dd>>< return -1;
<dd>>< }
<dd>>< strncpy(name, peer->name, sizeof(name) - 1);
<dd>>< peer->lastmsgsent_switch[i] = ((newmsgs << 8) |
(oldmsgs));
<dd>>< if (create_addr(p, name)) {
<dd>>&lt
<dd>; /* Maybe they're not registered, etc. */
<dd>>< sip_destroy(p);
<dd>>< return 0;
<dd>>< }
<dd>>< /* Recalculate our side, and recalculate Call ID */
<dd>>< if
(ast_sip_ouraddrfor(&p->sa.sin_addr,&p->ourip))
<dd>>< memcpy(&p->ourip, &__ourip,
sizeof(p->ourip));
<dd>>< build_via(p, p->via, sizeof(p->via));
<dd>>< build_callid(p->callid, sizeof(p->callid),
p->ourip,
<dd>>p->fromdomain);
<dd>>< /* Here I call another Function to Build Proper to header
*/
<dd>>< /* Sen d MWI */
<dd>>< ast_set_flag(p, SIP_OUTGOING);
<dd>><
<dd>>< //Ujju Set the p->peername pointer to char to NULL
<dd>>if its length is 0
<dd>><
<dd>>< if (!strlen(p->peername)){
<dd>>< strncpy(p->peername, peer->name,
sizeof(p->peername));
<dd>>< }
<dd>><
<dd>><
<dd>>< transmit_notify_to_softswitch_with_mwi(p, mbox[i],
<dd>>newmsgs, oldmsgs);
<dd>>&l
<dd>t; ; sip_scheddestroy(p, 15000);
<dd>>< }
<dd>><
<dd>><
<dd>><
<dd>>< return 0;
<dd>><
<dd>>< }
<dd>><
<dd>><
<dd>><
<dd>>8743,8750c8574
<dd>>< /* Ujju Here we call function to separate all the mailboxes
<dd>>if tohost ne NULL and
<dd>>< then call the below func - sip_send_mwi_to_softswitch -
<dd>>for each of those mailboxes */
<dd>><
<dd>>< if (strlen(peer->tohost) != 0){
<dd>>< sip_send_mwi_to_softswitch(peer);
<dd>>< return 0;
<dd>>< }
<dd>><
<dd>>---
<dd>>> /* Check for messages */
<dd>>
<dd>>
<dd>>
<dd>>Do you Yahoo!?
<dd>>Yahoo! Small Business -
<dd>>Try
<dd>>our new resources site!
<dd>>
<dd>>_______________________________________________
<dd>>Asterisk-Dev mailing list
<dd>>Asterisk-Dev@lists.digium.com
<dd>><a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" eudora="autourl">http://lists.digium.com/mailman/listinfo/asterisk-dev</a>
<dd>>To UNSUBSCRIBE or update options visit:
<dd>>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" eudora="autourl">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br><br>
</dl><br><br>
<br>
Do you Yahoo!?<br>
Yahoo! Mail - 250MB free storage.
<a href="http://us.rd.yahoo.com/evt=29915/*http://info.mail.yahoo.com/mail_250">Do
more. Manage less.</a> <br>
_______________________________________________<br>
Asterisk-Dev mailing list<br>
Asterisk-Dev@lists.digium.com<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" eudora="autourl">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" eudora="autourl">http://lists.digium.com/mailman/listinfo/asterisk-dev</a>
</blockquote></body>
</html>