[asterisk-dev] GitHub: Side Note: What makes us "special"?

asterisk at phreaknet.org asterisk at phreaknet.org
Tue Apr 4 15:30:19 CDT 2023


On 4/4/2023 4:26 PM, George Joseph wrote:
> On Tue, Apr 4, 2023 at 1:16 PM <asterisk at phreaknet.org> wrote:
>
>> On 4/4/2023 2:53 PM, George Joseph wrote:
>>> <snip>
>>>
>>>
>>>    * Is there any connection with reviews/PRs in progress? Suppose an
>>>      issue is open and maybe on the verge of being stale, but someone has
>>>      submitted a PR against. Changes can often take much longer than 3
>>>      weeks to merge, so it wouldn't make sense for an issue to close
>>>      itself in that case. So I'm concerned perhaps that might not be
>>>      sufficient time.
>>>
> We're still thinking about the issues process but...
>
> The action allows you to specify labels that make an issue exempt from
> auto-closure.  I was thinking that when a PR gets submitted, we'd look for
> the "Resolves: #issuenum" tag in the commit message, then add an
> "InProgress" label to the issue to prevent it from being auto closed.  The
> issue would then get closed when the PR is closed.
>
> I'm also thinking it would only close issues that have been inactive and
> assigned to the submitter.  Like the "Waiting for Feedback" status in Jira.
>
> Does that make sense?
That makes sense, that seems like it would replicate the current 
behavior pretty nicely.
Thanks, George!



More information about the asterisk-dev mailing list