[asterisk-dev] pjsip headers and dlg->pool vs tdata->pool

[Alex Hermann]

Hi,

Recently a commit by Kevin Harwell changed a single pjsip_hdrs_clone()'s 
usage of the dlg pool to use the tdata pool instead.

https://gerrit.asterisk.org/c/asterisk/+/18273/3

I don't understand why this change is only needed when creating an 
outgoing request. Why is this not changed for an incoming request? Is 
there documentation on when to use which pool? Or was this simply an 
omission and should the other usage(s) change too?

res/res_pjsip_header_funcs.c:202:

static int insert_headers(pj_pool_t * pool, ....
               le->hdr = pjsip_hdr_clone(pool, hdr);

(pool is dlg->pool here, called from incoming_request())
-- 
Alex Hermann