[asterisk-dev] Looking for help with gerrit for submitting an issue fix for review

[Dan Cropp]

Attempting to go through the Gerrit Usage instructions again this week.

Last week, I was able to clone from gerrit, I branched the issue I was working on, made changes and ran tests.  I was able to commit locally, but could not push the changes back to gerrit.   I receive the prompt for the Username https://gerrit.asterisk.org and password for https://myusername@gerrit.asterisk.org

I have confirmed my credentials on gerrit.

When I execute git remote -v
origin  http://gerrit.asterisk.org/asterisk (fetch)
origin  http://gerrit.asterisk.org/asterisk (push)


This week, I decided to create a different directory on my Linux VM and attempt to follow the Gerrit Usage instructions again.
Now, I'm having trouble cloning from gerrit.

git clone ssh://asterisk/master
Cloning into 'master'...
fatal: project master not found
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Also tried...

git clone ssh://myusername@gerrit.asterisk.org:29418/master
Cloning into 'master'...
fatal: project master not found
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.


It would seem this statement would be true.  
"Failure to set your username will result in clones using SSH failing, despite adding your SSH key. If you can not clone using SSH please ensure you have set your username."

However, I have re-entered my SSH key and it's still failing.

Can anyone provide some guidance?

Dan

-----Original Message-----
From: asterisk-dev <asterisk-dev-bounces at lists.digium.com> On Behalf Of Matt Fredrickson
Sent: Friday, March 29, 2019 3:39 PM
To: Asterisk Developers Mailing List <asterisk-dev at lists.digium.com>
Subject: Re: [asterisk-dev] Looking for help with gerrit for submitting an issue fix for review

On Fri, Mar 29, 2019 at 3:18 PM Dan Cropp <dan at amtelco.com> wrote:
>
> I have an issue fix I would like to commit for review.
>
>
>
> I was able to retrieve the asterisk master code from gerrit, edit the code, and put it through tests.
>
> I believe I have everything completed with the git message.
>
>
>
> When I try to submit it for review… (git review master)
>
>
>
> I am seeing the following…
>
>
>
> Could not connect to gerrit.
>
> Enter your gerrit username: daninmadison
>
> Trying again with 
> ssh://daninmadison@gerrit.asterisk.org:29418/asterisk.git
>
> <traceback object at 0x7f1da0fbbef0>
>
> We don't know where your gerrit is. Please manually create a remote
>
> named "gerrit" and try again.
>
> Could not connect to gerrit at 
> ssh://daninmadison@gerrit.asterisk.org:29418/asterisk.git
>
> Traceback (most recent call last):
>
>   File "/usr/bin/git-review", line 10, in <module>
>
>     sys.exit(main())
>
>   File "/usr/lib/python2.7/dist-packages/git_review/cmd.py", line 
> 1534, in main
>
>     sys.exit(e.EXIT_CODE)
>
> AttributeError: 'GitReviewException' object has no attribute 'EXIT_CODE'
>
>
>
> Could someone provide some guidance on what I am doing wrong?

Do you have a remote called gerrit when you type git remote?

If you're not using it, the page that I usually use when setting up a new contribution repo is https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

Best wishes!

--
Matthew Fredrickson
Digium - A Sangoma Company | Asterisk Project Lead
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev