[asterisk-dev] PJSIP Dialog-Info+XML enhancement

[Joshua C. Colp]

On Wed, Nov 14, 2018, at 5:43 PM, Hans-Peter Jansen wrote:

<snip>

> 
> Great, thanks, will look into this in the next few days...
> 
> > Can you clarify
> > what you mean by "Remote is still wrong".
> 
> The remote entry:  
>   <remote>
>    <identity display>sip:000413414123 at 192.168.23.2</identity>
>    <target uri="sip:000413414123 at 192.168.23.2" />
>   </remote>
> should look like:
>   <remote>
>    <identity display="">sip:012345678900 at 192.168.23.2</identity>
>    <target uri="sip:012345678900 at 192.168.23.2"/>
>   </remote>
> 
> IOW, it should display the caller, not the sip address of the callee (which 
> isn't immediately obvious indeed, sorry for being too sparse here..). 000413 
> is the Snom manufacturer ethercode...
> 
> What the code needs is fetching the caller from the callee. The sip code does 
> something similar to what I'm doing here:
> 
> 	char *remote = ast_strdupa(state_data->remote);
> 
> but this seems to point to the callee (ringing device) for some reason.

Does find_ringing_channel not find the channel or something? Is that information incorrect on the channel? Is it getting overwritten by the existing code?

-- 
Joshua C. Colp
Digium - A Sangoma Company | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org