[asterisk-dev] Add missing XML tags in pjsip NOTIFY for RFC4235

[Ludovic Gasc]

>
> On Fri, Oct 13, 2017 at 3:21 PM, Ludovic Gasc <gmludo at gmail.com> wrote:
>
>> Hi,
>>
>> Certainly as you, we have more and more phone brands who are capable to
>> read the XML from a NOTIFY when a phone rings to extract callerid and show
>> that on the screen.
>>
>> The issue is that it doesn't work on chan_sip, not planned to be fixed:
>> https://issues.asterisk.org/jira/browse/ASTERISK-24488
>>
>> Moreover, the situation is worse with pjsip, because we have less
>> information:
>> https://issues.asterisk.org/jira/browse/ASTERISK-26454
>>
>> For now, we have a backup plan with something similar of this:
>> https://github.com/kettenbach-it/asterisk-snom-pickup-info-xml-agi
>> But with a better scalability and based on AMI command MessageSend, to be
>> NAT compliant: https://wiki.asterisk.org/wiki/display/AST/Asteri
>> sk+13+ManagerAction_MessageSend
>>
>> However, we have now an internal incentive to have an integrated solution
>> directly in Asterisk.
>>
>> We have an internal C developer who can work on it full-time, but before
>> to follow the rabbit in the hole, I'm pretty sure that if it was simply to
>> enrich this function:
>> https://github.com/asterisk/asterisk/blob/master/res/res_pjs
>> ip_dialog_info_body_generator.c#L101
>> The patch was already made and merged a long time ago.
>>
>> Is it a way exists to implement that or it needs to re-implement a part
>> of Asterisk ?
>>
>
> Hi Ludovic,
>
> Yep, that's the place.  dialog_info_generate_body_content is the function
> you want to extend.   Just don't modify any of the existing attributes and
> if you need to add data fields to the ast_sip_exten_state_data structure
> (or any public structure) make sure to do so at the end of the structure to
> preserve binary compatibility.
>

Hi George,

Certainly as people before us, we didn't find an obvious way to add that
easily.
We are working on a B plan with an external daemon, because it's easier to
us to maintain.
Maybe we might publish something under an open source license at the end, I
don't know yet.

Regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20171106/6cbc3233/attachment.html>