[asterisk-dev] Possible change to the AMI PJSIPShowRegistrationsInbound command

George Joseph gjoseph at digium.com
Wed Dec 7 12:24:11 CST 2016


On Wed, Dec 7, 2016 at 8:34 AM, George Joseph <gjoseph at digium.com> wrote:

>
>
> On Wed, Dec 7, 2016 at 8:16 AM, Matthew Jordan <mjordan at digium.com> wrote:
>
>>
>>
>> On Tue, Dec 6, 2016 at 4:27 PM, Matt Fredrickson <creslin at digium.com>
>> wrote:
>>
>>> On Tue, Dec 6, 2016 at 12:30 PM, Joshua Colp <jcolp at digium.com> wrote:
>>> > On Tue, Dec 6, 2016, at 10:43 AM, George Joseph wrote:
>>> >> We just discovered that the PJSIPShowRegistrationsInbound command
>>> really
>>> >> only dumps all aors regardless of whether there's an inbound
>>> registration
>>> >> associated with it or not.  Fixing this would mean a change to what
>>> this
>>> >> command returns so I'm trying to get some feedback.  There are 2
>>> solution
>>> >> alternatives...
>>> >>
>>> >> 1.  We could replace the current InboundRegistrationDetail event
>>> (which
>>> >> isn't even registered) with a ContactStatusDetail event.  Obviously
>>> this
>>> >> is
>>> >> a change for anyone who uses this command.
>>> >>
>>> >> 2.  We could send a ContactStatusDetail event along with the existing
>>> >> InboundRegistrationDetail event.  This would double the number of
>>> events
>>> >> sent and therefore increase the total data sent.
>>> >>
>>> >> Honestly I'm not sure how this command was ever useful to anybody so
>>> I'm
>>> >> leaning towards option 1 but we need feedback.
>>> >>
>>> >> This would be a change to 13, 14 and master.
>>> >
>>> > Since it was not really useful I'm okay with 1.
>>>
>>> Just as something to consider:
>>>
>>> If we make breaking changes to AMI, this would require a major number
>>> version bump, right?
>>>
>>>
>> Yes, it would.
>>
>
> AMI versions bumped:
> Branch 13: 3.0.0
> Branch 14 and master: 4.0.0
>


OK, We backtracked on this:

A new command was added PJSIPShowRegistrationInboundContactStatuses instead
of modifying the old one.  No version bumps of any kind
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20161207/6f2dc16c/attachment.html>


More information about the asterisk-dev mailing list