[asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/#review14985
-----------------------------------------------------------

Ship it!


There's only one finding left and it's just to swap two lines of code, so I'm giving a ship it!


/branches/13/apps/app_minivm.c
<https://reviewboard.asterisk.org/r/4541/#comment25609>

    The if check here should be before the ast_copy_string() operation. Basically, setting oldlocale to something in the case that etemplate->locale is zero-length is a wasted operation since we will not end up doing anything with oldlocale in that case.


- Mark Michelson


On March 31, 2015, 4:05 p.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4541/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 4:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
>     https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs.
> 
> clang compiler warning:-Wpointer-bool-conversion
> 
> Issues:
> chan_pjsip.c:1898:13: warning: address of array 'data->text' will always evaluate to 'true' [-Wpointer-bool-conversion]
>         if (!data->text) {
>             ~~~~~~~^~~~
> app_minivm.c:1841:18: warning: address of array 'etemplate->locale' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                 if (etemplate->locale) {
>                 ~~  ~~~~~~~~~~~^~~~~~
> app_minivm.c:1871:17: warning: address of array 'etemplate->locale' will always evaluate to 'true' [-Wpointer-bool-conversion]
>         if (etemplate->locale) {
>         ~~  ~~~~~~~~~~~^~~~~~
> app_queue.c:6686:19: warning: address of array 'qe->parent->monfmt' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                 if (qe->parent->monfmt && *qe->parent->monfmt) {
>                     ~~~~~~~~~~~~^~~~~~ ~~
> app_queue.c:9090:15: warning: address of array 'mem->state_interface' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                                         if (mem->state_interface) {
>                                         ~~  ~~~~~^~~~~~~~~~~~~~~
> res_smdi.c:876:19: warning: address of array 'search_msg->mesg_desk_num' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                 if (search_msg->mesg_desk_num) {
>                 ~~  ~~~~~~~~~~~~^~~~~~~~~~~~~
> res_smdi.c:879:19: warning: address of array 'search_msg->mesg_desk_term' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                 if (search_msg->mesg_desk_term) {
>                 ~~  ~~~~~~~~~~~~^~~~~~~~~~~~~~
> 
> Changed: removed the superfluous checks
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_smdi.c 433444 
>   /branches/13/channels/chan_pjsip.c 433444 
>   /branches/13/apps/app_queue.c 433444 
>   /branches/13/apps/app_minivm.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4541/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150331/088d8ad4/attachment.html>