[asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4563/#review14970
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On March 30, 2015, 2:23 p.m., Valentin Vidić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4563/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 2:23 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-18032
>     https://issues.asterisk.org/jira/browse/ASTERISK-18032
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When udpbindaddr=:: is set Asterisk accepts IPv4 and IPv6 clients both stored in a struct sockaddr_in6 with AF_INET6 family type. Current NAT code for IPv4 checks if the socket type is AF_INET6 and thus fails to handle IPv4 mapped addresses properly. The patch adds an additional check for this case allowing IPv4 clients to be handled by NAT even when IPv6 is enabled.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 433794 
> 
> Diff: https://reviewboard.asterisk.org/r/4563/diff/
> 
> 
> Testing
> -------
> 
> Patch solves the problem of failing incoming calls on a local NATed installation with IPv6 sockets enabled.
> 
> 
> Thanks,
> 
> Valentin Vidić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150331/749bfeba/attachment-0001.html>