[asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

[Diederik de Groot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/#review14954
-----------------------------------------------------------



/branches/13/include/asterisk/utils.h
<https://reviewboard.asterisk.org/r/4543/#comment25572>

    superfluous null pointer check removed after some testing



/branches/13/configure.ac
<https://reviewboard.asterisk.org/r/4543/#comment25571>

    move the raii compiler checks to their own m4 file and called the checking function a little earlier in the configure process


- Diederik de Groot


On March 29, 2015, 4:57 a.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4543/
> -----------------------------------------------------------
> 
> (Updated March 29, 2015, 4:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
>     https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> RAII-clang reentrancy / Updating variable from inside a _block
> 
> To update the varname variable from inside the cleanup block it needs to be decorated with "__block" as in:
> __block vartype varname = ctor;
> 
> 
> Diffs
> -----
> 
>   /branches/13/include/asterisk/utils.h 433444 
>   /branches/13/contrib/scan-build PRE-CREATION 
>   /branches/13/configure.ac 433444 
>   /branches/13/autoconf/ast_check_raii.m4 PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150329/ca8dea9d/attachment.html>