[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

[Corey Farrell (Code Review)]

Corey Farrell has posted comments on this change.

Change subject: Memory Debugging Improvements
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/15/2/contrib/valgrind/text-summary.xsl
File contrib/valgrind/text-summary.xsl:

Line 4: <xsl:output method="text" omit-xml-declaration="yes" indent="no"/>
> Looking at this XSLT, it is frustrating to have to use XML comments to prop
I think generating an HTML file would be nice, but that doesn't accomplish the goal of this plain text output - to display a summary of errors, leaks and suppressions to stdout and the failure_message.

So while I agree that HTML would be nice, it's an addition not a replacement.  Another thought I was just having, I could do 2 stage processing for the plain text output.  Process with 1 XSL that will produce:
<text>
<line>line 1 output</line>
...
</text>

Then either have another XSL translate the list of lines, or just iterate the DOM in python.


https://gerrit.asterisk.org/#/c/15/2/lib/python/asterisk/asterisk.py
File lib/python/asterisk/asterisk.py:

Line 363:                 suppression_file = 'contrib/valgrind/suppressions.txt'
> Asterisk also comes with a suppressions file. Is there a reason to not use 
Additional options are not easily passed from ./runtests.py to the actual tests.  This is why VALGRIND_ENABLE is an environmental variable.  For this reason I think having the user specify the suppression file would be difficult.  Providing a specific place for them to put the suppressions is much simpler.  Note that contrib/valgrind/suppressions.txt is in .gitignore, so the user choice is if they should put a file there.

Using files from the Asterisk source is troublesome, finding the source location is unreliable.  Since the example suppression file is not installed...


-- 
To view, visit https://gerrit.asterisk.org/15
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21634673508a01eea1f489c751d3cf75ea55cf06
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes