[asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

[Diederik de Groot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4546/#review14935
-----------------------------------------------------------



/branches/13/configure.ac
<https://reviewboard.asterisk.org/r/4546/#comment25549>

    Added to illustrate that the bits/string2.h is not completely broken and could be used, using a char[]. This extra check should be removed before committing to the repository



/branches/13/configure.ac
<https://reviewboard.asterisk.org/r/4546/#comment25550>

    This check should be folded into main when test1 is removed. There is no real need to test both strsep and strcmp, they both come down to the same issue in the way __string2_1bptr_p is used


bootstrap.sh is needed before committing this to the repository to update configure and include/asterisk/autoconfig.h.in


- Diederik de Groot


On March 28, 2015, 3:01 p.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4546/
> -----------------------------------------------------------
> 
> (Updated March 28, 2015, 3:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
>     https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs. clang compiler warning:-Warray-bounds
> 
> 
> Diffs
> -----
> 
>   /branches/13/configure.ac 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4546/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150328/637f659b/attachment.html>