[asterisk-dev] [Code Review] 4388: Testsuite: Test for res_pjsip_config_wizard auto-create hints.

[Ashley Sanders]

> On March 25, 2015, 10:24 a.m., Ashley Sanders wrote:
> > asterisk/trunk/tests/channels/pjsip/config_wizard/hints/test-config.yaml, line 8
> > <https://reviewboard.asterisk.org/r/4388/diff/1/?file=71178#file71178line8>
> >
> >     This needs to be updated to reflect the version in which the feature added.
> 
> George Joseph wrote:
>     Wow, I forgot all about this.  The feature did go in and I just forgot to commit the test.  I'm going to discard this review and resubmit via gerrit/git.
>

:) Don't feel bad; I also forgot to update the minversion attribute in my test and it came up in my code review, too.


- Ashley


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4388/#review14834
-----------------------------------------------------------


On March 26, 2015, 11:40 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4388/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 11:40 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Testsuite:  Test for res_pjsip_config_wizard auto-create hints.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/tests.yaml 6348 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/hints/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/hints/configs/ast1/pjsip_wizard.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/hints/configs/ast1/pjsip.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4388/diff/
> 
> 
> Testing
> -------
> 
> Test passes.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150327/d972b26b/attachment-0001.html>