[asterisk-dev] [Code Review] 4537: clang compiler warning: -Wbitfield-constant-conversion

[Diederik de Groot]

> On March 27, 2015, 2:26 p.m., Matt Jordan wrote:
> > /branches/13/channels/chan_iax2.c, line 11898
> > <https://reviewboard.asterisk.org/r/4537/diff/1/?file=72997#file72997line11898>
> >
> >     Interestingly enough, we don't use this value anywhere :-P
> >     
> >     But that's a different problem.

You are right, maybe we should schedule this bitfield for removal then.


- Diederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4537/#review14897
-----------------------------------------------------------


On March 27, 2015, 12:24 p.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4537/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 12:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
>     https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs. 
> 
> clang compiler warning:-Wbitfield-constant-conversion
> 
> Changes:
> chan_iax2.c:11898:18: warning: implicit truncation from 'int' to bitfield changes value from -1 to 1 [-Wbitfield-constant-conversion]
>                 fr->outoforder = -1;
> Changed to fr->outoforder = 1;
> 
> 
> Diffs
> -----
> 
>   /branches/13/channels/chan_iax2.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4537/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150327/7cddfb27/attachment.html>